From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: RE: wrong-type-argument in gud-tooltip-mode Date: Sun, 27 Jan 2008 23:30:27 +1300 Message-ID: <18332.23875.678987.641297@kahikatea.snap.net.nz> References: <18331.51852.195134.607586@kahikatea.snap.net.nz> <18332.10233.967027.718374@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1201429859 6938 80.91.229.12 (27 Jan 2008 10:30:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Jan 2008 10:30:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Herbert Euler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 27 11:31:18 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JJ4nF-0001wj-El for ged-emacs-devel@m.gmane.org; Sun, 27 Jan 2008 11:31:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJ4mo-0005zI-J0 for ged-emacs-devel@m.gmane.org; Sun, 27 Jan 2008 05:30:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJ4mk-0005yu-4P for emacs-devel@gnu.org; Sun, 27 Jan 2008 05:30:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJ4mh-0005xs-IA for emacs-devel@gnu.org; Sun, 27 Jan 2008 05:30:44 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJ4mh-0005xp-Ep for emacs-devel@gnu.org; Sun, 27 Jan 2008 05:30:43 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JJ4mg-0002QI-TX for emacs-devel@gnu.org; Sun, 27 Jan 2008 05:30:43 -0500 Original-Received: from kahikatea.snap.net.nz (162.63.255.123.dynamic.snap.net.nz [123.255.63.162]) by viper.snap.net.nz (Postfix) with ESMTP id 1406A3DA215; Sun, 27 Jan 2008 23:30:33 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 8D5D98FC6D; Sun, 27 Jan 2008 23:30:28 +1300 (NZDT) In-Reply-To: X-Mailer: VM 7.19 under Emacs 23.0.60.5 X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87633 Archived-At: > > Also I've tried to reproduce the error in emacs-unicode-2 and on the trunk > > but can't. > > It is easy to reproduce now, even without gdb. Since the buffer > " *partial-output-*" does not visit any file, the FILE argument provided > to `file-exists-p' will be nil. However, > > (file-exists-p nil) > error--> Wrong type argument: stringp, nil > > That is the error. Yes, that is easy! I can see it in the *Messages* buffer now. I was fooled because I thought I'd see any error in the mini-buffer. I'm a bit confused about when errors do get printed there now. How about the patch below. There seems to be no point in running call-process with no input file. I could probably also remove the string-match for "\\`\\*.+\\*\\'" in gud-tooltip-mode too, as these buffers have no files associated with them anyway. -- Nick http://www.inet.net.nz/~nickrob *** gdb-ui.el.~1.218.~ 2008-01-23 17:34:20.000000000 +1300 --- gdb-ui.el 2008-01-27 23:06:38.000000000 +1300 *************** otherwise do not." *** 435,445 **** (output (with-output-to-string (with-current-buffer standard-output ! (call-process shell-file-name ! (if (file-exists-p file) file nil) (list t nil) nil "-c" (concat gdb-cpp-define-alist-program " " ! gdb-cpp-define-alist-flags))))) (define-list (split-string output "\n" t)) (name)) (setq gdb-define-alist nil) (dolist (define define-list) --- 435,445 ---- (output (with-output-to-string (with-current-buffer standard-output ! (and file (file-exists-p file) ! (call-process shell-file-name file (list t nil) nil "-c" (concat gdb-cpp-define-alist-program " " ! gdb-cpp-define-alist-flags)))))) (define-list (split-string output "\n" t)) (name)) (setq gdb-define-alist nil) (dolist (define define-list)