From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Wed, 26 Dec 2007 11:05:23 +1300 Message-ID: <18289.32419.531826.713148@kahikatea.snap.net.nz> References: <8763yn3v07.fsf@member.fsf.org> <87prwu3kg0.fsf@member.fsf.org> <87prwu77ug.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1198620382 21358 80.91.229.12 (25 Dec 2007 22:06:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 22:06:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 23:06:35 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7Huc-0001TU-5H for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 23:06:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7HuG-0001mL-8X for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 17:05:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7HuA-0001ix-VK for emacs-devel@gnu.org; Tue, 25 Dec 2007 17:05:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7Hu8-0001eF-8w for emacs-devel@gnu.org; Tue, 25 Dec 2007 17:05:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7Hu8-0001dv-2m for emacs-devel@gnu.org; Tue, 25 Dec 2007 17:05:40 -0500 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7Hu7-0005iO-Ii for emacs-devel@gnu.org; Tue, 25 Dec 2007 17:05:39 -0500 Original-Received: from kahikatea.snap.net.nz (152.31.255.123.static.snap.net.nz [123.255.31.152]) by viper.snap.net.nz (Postfix) with ESMTP id AF77D3DA17B; Wed, 26 Dec 2007 11:05:37 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 4DC2C8FC6D; Wed, 26 Dec 2007 11:05:24 +1300 (NZDT) In-Reply-To: <87prwu77ug.fsf@member.fsf.org> X-Mailer: VM 7.19 under Emacs 23.0.50.15 X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85460 Archived-At: > here's the implementation of your idea and doc-view using it. > > --8<---------------cut here---------------start------------->8--- > 2007-12-25 Tassilo Horn > > * bookmark.el (bookmark-make-cell-function): New variable. > (bookmark-make): Call bookmark-make-cell-function's function > instead of bookmark-make-cell. > (bookmark-get-handler): New function. > (bookmark-jump, bookmark-jump-other-window, bookmark-insert) > (bookmark-bmenu-2-window, bookmark-bmenu-other-window): Use the > bookmark's handler function if it has one defined. > (bookmark-make-cell-for-text-file): Renamed from > bookmark-make-cell. > > * doc-view.el (doc-view-bookmark-make-cell) > (doc-view-bookmark-jump): New functions. > (doc-view-mode): Set bookmark-make-cell-function buffer-locally. > --8<---------------cut here---------------end--------------->8--- > > Here's the patch: > > --8<---------------cut here---------------start------------->8--- > Index: lisp/doc-view.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/doc-view.el,v As an aside, if you attach your patch at the end of your e-mail, the diff should apply cleanly without the need for "cut here" markers. -- Nick http://www.inet.net.nz/~nickrob