From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Maxim Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#12972: [PATCH] Avoid regression in mailcap-view-file similar to Bug#44824 Date: Sat, 3 Jul 2021 18:29:30 +0700 Message-ID: <1825a6f3-0175-2d67-5608-41c9fb93889b@gmail.com> References: <87r1hmdqek.fsf__16088.3597027109$1622530682$gmane$org@gnus.org> <835yxtlw14.fsf__2546.8955327355$1625164803$gmane$org@gnu.org> <1ddf1c46-0a28-4a2d-cc40-094ff74ee0ac@gmail.com> <837di8ki24.fsf__46278.4886871063$1625229533$gmane$org@gnu.org> <831r8gk4m0.fsf__14172.0669272885$1625246977$gmane$org@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9303"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 To: 12972@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 03 13:30:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzdqy-0002KG-93 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jul 2021 13:30:32 +0200 Original-Received: from localhost ([::1]:54026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzdqw-0002sF-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Jul 2021 07:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzdqV-0002qZ-8I; Sat, 03 Jul 2021 07:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54665) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzdqV-0008ST-0s; Sat, 03 Jul 2021 07:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzdqU-00082a-LI; Sat, 03 Jul 2021 07:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Maxim Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Sat, 03 Jul 2021 11:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12972 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 12972-submit@debbugs.gnu.org id=B12972.162531178130852 (code B ref 12972); Sat, 03 Jul 2021 11:30:02 +0000 Original-Received: (at 12972) by debbugs.gnu.org; 3 Jul 2021 11:29:41 +0000 Original-Received: from localhost ([127.0.0.1]:37978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzdq9-00081Y-5h for submit@debbugs.gnu.org; Sat, 03 Jul 2021 07:29:41 -0400 Original-Received: from mail-lj1-f180.google.com ([209.85.208.180]:36514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzdq6-00081G-Qu for 12972@debbugs.gnu.org; Sat, 03 Jul 2021 07:29:39 -0400 Original-Received: by mail-lj1-f180.google.com with SMTP id a6so17285939ljq.3 for <12972@debbugs.gnu.org>; Sat, 03 Jul 2021 04:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m+ABobPGrlMRHd6M92VSJY25iLxCWMykU3frB5Ik1h8=; b=bMw+hflcyj87IU5FvJqKAxhOUFEfbzzx8K9OLfd9Ac/vA8u9ft+3nbiwX9/wzhY3PI XHz+KCGiXCnTa90z+QhY74nXAX0WptykykCYM4YycfFLmiC/+ydgWIO54vJcz1nxFq0i wge8EMOIsO8VnkuVmQF9Enhoqmnt+ZHhAOjvlM32keaNzt9Q4kwP6jmELcFabJL/f/Af 7mujSIZHDzkH8pWm/781gOQQZIx7oblK5aTNkfjXmN6Hbp/PoqxfETDIk7aIlSOv8+AN vuJH0f/KXIglMaDHwvMk0f6g9UOT+NpT3Rc1Qn/GmYOLoRLZ2pXDarxJe5gOW9qjMcCi 7DVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m+ABobPGrlMRHd6M92VSJY25iLxCWMykU3frB5Ik1h8=; b=dfIB1uLcComY2Q4qmosuda2R2rz0OG9uEMpxH6MucFZIa8Xzms3Scbv/6UOnJ+2qnl VyJOGGUiHm2ZHxAduaxOeo+5e/xfaHL6WdJoBtzhDOp5ejPeGToSPxVxh8G20LmA8CPb NUiNWc0spV9/5GgnIr4SaV5C+5653VM8Nd7ffOe97Vc2bOWaQZL0FDeB0ILMaSIW3yzM M/iNpwYJMVZ/eEEv1oGBT28j1/KjkbzvTXIzvxMcUPA+ehzaXqXhSHKsDoEGEYJLu3Oi 2x2Lhy3k10SPEgFlo3f5hlLGzUMkR4Q8hlk0dXjgGXQB3gqfX/dj6SNZW8ka55sNlcOq ybHw== X-Gm-Message-State: AOAM533DRmAd/RGmvPYEesKs7drVDISUjJ2/4sOtF7pt0FF6n0718Uro W5WTc2UM4jv23xUwwatAsFWnxpvbAFs= X-Google-Smtp-Source: ABdhPJzfEh+wxEdYjwykyZKmrIqrjWKAoR/2sRI9lTuNI3P3+h+Noq+CVz1kgC5/Q4WjWJfYR71vsg== X-Received: by 2002:a2e:9608:: with SMTP id v8mr2050749ljh.206.1625311772366; Sat, 03 Jul 2021 04:29:32 -0700 (PDT) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id u24sm522268lfc.162.2021.07.03.04.29.31 for <12972@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Jul 2021 04:29:31 -0700 (PDT) In-Reply-To: <831r8gk4m0.fsf__14172.0669272885$1625246977$gmane$org@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209359 Archived-At: I am giving up with this issue. My summary. New function `mailcap-view-file' has a problem similar to Bug#44824 (kde-open5 and "gio open" called directly or through xdg-open are unreliable in Emacs, I consider it as fixed in Org mode) that was reported by several users and refused by developers as not reproducible at first. I tried my best to draw attention to this problem and then to suggest a change that fixes the obscure problem and improves error handling. I am unaware of any real negative consequences of my patch. It is up to Emacs developers to leave the new bug as is or to fix it in a way they like On 03/07/2021 00:28, Eli Zaretskii wrote: >> From: Maxim Nikulin Date: Fri, 2 Jul 2021 23:24:23 +0700 >> >> On 02/07/2021 19:37, Eli Zaretskii wrote: >>>> From: Maxim Nikulin Date: Fri, 2 Jul 2021 19:21:55 +0700 >>>> >>>>> And with other handlers, this could be an >>>>> incompatible behavior change if the handler behaves differently when >>>>> its standard handles are connected to a pipe rather than a terminal >>>>> device. >>>> >>>> Example of such handler, please. >>> >>> Why do you need one? >> >> Because of I can not imagine such case for mailcap handler in Emacs yet >> and, accordingly to you, "this could be an incompatible behavior change". > > You don't need to imagine it, you just need to trust me that I know > what I'm talking about: it would be an incompatible change. Is it a kind of Church of Emacs that I have to just believe in you? Previous time you were trying to convince me that unconditional 'pipe is perfectly safe when I was unsure concerning behavior on Windows. You prefer to keep reasons of your objections unveiled. I see no issue with the patch. It can be by a few lines shorter but the price is worse user experience. I have no idea how to move further. Finally, the patch touches month-old unreleased code, so I see no point to discuss that it is "incompatible". P.S. It was my fault to use `make-process' in Org since the function is not available in Emacs-24. I'm sorry for that incompatibility.