From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "T. V. Raman" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; Cannot run calculator on TTY Date: Mon, 1 Oct 2007 20:13:46 -0700 Message-ID: <18177.46954.59945.891659@gargle.gargle.HOWL> References: <20071001023514.E164D12A4071@localhost> <470090AD.7020701@gmx.at> <18176.62320.27921.579761@gargle.gargle.HOWL> <4701153E.7010408@gmx.at> Reply-To: raman@users.sf.net NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191294851 2670 80.91.229.12 (2 Oct 2007 03:14:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2007 03:14:11 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, raman@users.sf.net To: rudalics@gmx.at Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 05:14:07 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IcYCz-0004jj-Lz for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2007 05:14:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IcYCv-0004T4-Gx for ged-emacs-devel@m.gmane.org; Mon, 01 Oct 2007 23:14:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IcYCr-0004PI-7l for emacs-devel@gnu.org; Mon, 01 Oct 2007 23:13:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IcYCm-0004N3-FQ for emacs-devel@gnu.org; Mon, 01 Oct 2007 23:13:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IcYCm-0004N0-9D for emacs-devel@gnu.org; Mon, 01 Oct 2007 23:13:52 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IcYCm-0000ps-5e for emacs-devel@gnu.org; Mon, 01 Oct 2007 23:13:52 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IcYBy-0008T2-9i for emacs-pretest-bug@gnu.org; Mon, 01 Oct 2007 23:13:02 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1IcYCi-0000p9-A3 for emacs-pretest-bug@gnu.org; Mon, 01 Oct 2007 23:13:51 -0400 Original-Received: from sccrmhc15.comcast.net ([204.127.200.85]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IcYCi-0000p5-2I for emacs-pretest-bug@gnu.org; Mon, 01 Oct 2007 23:13:48 -0400 Original-Received: from localhost (c-71-202-191-236.hsd1.ca.comcast.net[71.202.191.236]) by comcast.net (sccrmhc15) with ESMTP id <200710020313460150061jnfe>; Tue, 2 Oct 2007 03:13:47 +0000 Original-Received: by localhost (Postfix, from userid 1000) id 6A0BC12A4071; Mon, 1 Oct 2007 20:13:46 -0700 (PDT) In-Reply-To: <4701153E.7010408@gmx.at> X-Mailer: VM alpha-478 under Emacs 23.0.50.26 (i686-pc-linux-gnu) x-attribution: tvr X-Detected-Kernel: NetCache Data OnTap 5.x X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80114 gmane.emacs.pretest.bugs:20047 Archived-At: >>>>> "martin" == martin rudalics writes: >> Apologies about the Ad-orig -- that's because everything >> has been advised by Emacspeak. martin> martin> I understand. The problem is that apparently martin> martin> ad-Orig-calculator() martin> martin> wants to do martin> martin> split-window-vertically(-2) The problem is in the calculator.el code. My advice is benign --(will attach it here) but it's the original code, i.e. ad-Orig-calculator that is ending up with the bizarre -2. I tried to understand the code in calculator.el that does this but failed. Here is the advice I have on calculator: (defadvice calculator (after emacspeak pre act comp) "Speech enable calculator." (when (interactive-p) (emacspeak-auditory-icon 'open-object) (message "Welcome to the pocket calculator."))) All the above does is to speak a message and play a sound after the calculator is up. The problem lines in calculator.el appear to be: ;;; starting on line 734: (let ((split-window-keep-point nil) (window-min-height 2)) ;; maybe leave two lines for our window because of the normal ;; `raised' modeline in Emacs 21 (select-window (split-window-vertically ;; If the modeline might interfere with the calculator buffer, ;; use 3 lines instead. (if (and (fboundp 'face-attr-construct) (let* ((dh (plist-get (face-attr-construct 'default) :height)) (mf (face-attr-construct 'modeline)) (mh (plist-get mf :height))) ;; If the modeline is shorter than the default, ;; stick with 2 lines. (It may be necessary to ;; check how much shorter.) (and (not (or (and (integerp dh) (integerp mh) (< mh dh)) (and (numberp mh) (not (integerp mh)) (< mh 1)))) (or ;; If the modeline is taller than the default, ;; use 3 lines. (and (integerp dh) (integerp mh) (> mh dh)) (and (numberp mh) (not (integerp mh)) (> mh 1)) ;; If the modeline has a box with non-negative line-width, ;; use 3 lines. (let* ((bx (plist-get mf :box)) (lh (plist-get bx :line-width))) (and bx (or (not lh) (> lh 0)))) ;; If the modeline has an overline, use 3 lines. (plist-get (face-attr-construct 'modeline) :overline))))) -3 -2))) (switch-to-buffer calculator-buffer)) Notice the call to split-window-vertically above, and the somewhat complex code that determines the numeric argument being passed to that call. martin> martin> which eventually has `split-window' complain. If you martin> bind `window-min-height' to 2 around this the martin> complaints should go away, hopefully. Not sure what you mean. I got the code to work by deleting the split-window-vertically martin> call in my copy of calculator --which is not martin> completely right -- because obviously, I then end up with the calculator taking the whole martin> screen. martin> >> window-min-height is 4 -- I've not changed it. martin> martin> Did you change it earlier? No, I dont touch it. -- Best Regards, --raman Email: raman@users.sf.net WWW: http://emacspeak.sf.net/raman/ AIM: emacspeak GTalk: tv.raman.tv@gmail.com PGP: http://emacspeak.sf.net/raman/raman-almaden.asc Google: tv+raman IRC: irc://irc.freenode.net/#emacs