all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: `term' prefix for gpm support
Date: Sat, 22 Sep 2007 13:35:43 +1200	[thread overview]
Message-ID: <18164.29039.218922.86203@kahikatea.snap.net.nz> (raw)
In-Reply-To: <200709211426.l8LEQfuR010254@oogie-boogie.ics.uci.edu>

 >   > By the way, am I the only one annoyed by the Gpm code's use of the
 >   > `term' prefix?  I mean `term-open-connection' sounds like a very odd
 >   > choice of name for a function which "Open a connection to Gpm."
 > 
 > Agreed.  I would even say that the GPM code in term.c can go into a
 > separate file, that will reduce the amount of #ifdefs in term.c.

Maybe t-mouse-open, t-mouse-close would be better.  I can't recall how I
arrived at those names but it was probably convoluted.

There are four #ifdef HAVE_GPM blocks in term.c which doesn't seem that many
(term.c has 21 ifdefs in all).  More importantly, when I wrote it, the gpm code
called static functions in term.c like write_glyphs.  If after multi-tty these
functions are no longer part of term.c, maybe the gpm code can go into a
separate file.

I have no strong opinions about these issues and certainly don't mind if
someone wants to make changes.

-- 
Nick http://www.inet.net.nz/~nickrob

  reply	other threads:[~2007-09-22  1:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 14:05 `term' prefix for gpm support Stefan Monnier
2007-09-21 14:26 ` Dan Nicolaescu
2007-09-22  1:35   ` Nick Roberts [this message]
2007-09-22 20:00     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18164.29039.218922.86203@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.