From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "John W. Eaton" Newsgroups: gmane.emacs.bugs Subject: Re: Bug#443439: emacs: run-octave captures the shell directory tracker Date: Fri, 21 Sep 2007 11:44:14 -0400 Message-ID: <18163.59086.203111.308676@segfault.lan> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=unknown Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1190389410 16887 80.91.229.12 (21 Sep 2007 15:43:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 21 Sep 2007 15:43:30 +0000 (UTC) Cc: Andreas Schwab , bug-gnu-emacs@gnu.org, Octave bugs list , 443439-maintonly@bugs.debian.org To: Francesco Potorti` Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 21 17:43:28 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IYkf9-00079H-3w for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Sep 2007 17:43:27 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IYkf6-0003QH-Ld for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Sep 2007 11:43:24 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IYkf4-0003Od-LJ for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2007 11:43:22 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IYkf2-0003KW-QV for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2007 11:43:22 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IYkf2-0003KJ-Jw for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2007 11:43:20 -0400 Original-Received: from adsum.doit.wisc.edu ([144.92.197.210]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.60) (envelope-from ) id 1IYkex-0005w6-TJ; Fri, 21 Sep 2007 11:43:16 -0400 Original-Received: from avs-daemon.smtpauth1.wiscmail.wisc.edu by smtpauth1.wiscmail.wisc.edu (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JOQ00L0D6BTAX00@smtpauth1.wiscmail.wisc.edu>; Fri, 21 Sep 2007 10:43:05 -0500 (CDT) Original-Received: from segfault.lan (cpe-75-187-161-108.neo.res.rr.com [75.187.161.108]) by smtpauth1.wiscmail.wisc.edu (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JOQ00IQB6BR4840@smtpauth1.wiscmail.wisc.edu>; Fri, 21 Sep 2007 10:43:04 -0500 (CDT) In-reply-to: X-Mailer: VM 7.19 under Emacs 22.1.1 X-Spam-PmxInfo: Server=avs-9, Version=5.3.3.310218, Antispam-Engine: 2.5.2.313940, Antispam-Data: 2007.8.30.50928, SenderIP=75.187.161.108 X-Detected-Kernel: Solaris 10 (beta) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16590 Archived-At: On 21-Sep-2007, Francesco Potorti` wrote: | >This should use add-hook with LOCAL =3D t. |=20 | Good, thanks. So here is a correct patch: |=20 | 2007-09-21 Francesco Potort=EC |=20 | =09* progmodes/octave-inf.el (inferior-octave-mode): Use add-hook to | =09add inferior-octave-directory-tracker to the buffer-local value | =09of comint-input-filter-functions. |=20 | --- octave-inf.el=0921 Sep 2007 12:19:05 +0200=091.31 | +++ octave-inf.el=0921 Sep 2007 13:38:20 +0200=09 | @@ -153,10 +153,11 @@ Entry to this mode successively runs the | =20 | (setq comint-input-ring-file-name | =09(or (getenv "OCTAVE_HISTFILE") "~/.octave_hist") | -=09comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024) | -=09comint-input-filter-functions '(inferior-octave-directory-tracker= )) | +=09comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024)) | (set (make-local-variable 'comint-dynamic-complete-functions) | inferior-octave-dynamic-complete-functions) | + (add-hook 'comint-input-filter-functions | +=09'inferior-octave-directory-tracker nil t) | (comint-read-input-ring t) | =20 | (run-mode-hooks 'inferior-octave-mode-hook)) This patch does not apply cleanly to the octave-inf.el file that is distributed with Octave. I think the octave-{inf,mod,hlp}.el files that are included with Emacs have diverged from the versions that are distributed with Octave. It would be helpful if someone could reconcile the differences. Should we even continue to distribute these files with Octave? Thanks, jwe