Re: Bug#443439: emacs: run-octave captures the shell directory tracker

["John W. Eaton" <jwe@bevo.che.wisc.edu>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown, Size: 1545 bytes --]

On 21-Sep-2007, Francesco Potorti` wrote:

| >This should use add-hook with LOCAL = t.
| 
| Good, thanks.  So here is a correct patch:
| 
| 2007-09-21  Francesco Potortì  <pot@gnu.org>
| 
| 	* progmodes/octave-inf.el (inferior-octave-mode): Use add-hook to
| 	add inferior-octave-directory-tracker to the buffer-local value
| 	of comint-input-filter-functions.
| 
| --- octave-inf.el	21 Sep 2007 12:19:05 +0200	1.31
| +++ octave-inf.el	21 Sep 2007 13:38:20 +0200	
| @@ -153,10 +153,11 @@ Entry to this mode successively runs the
|  
|    (setq comint-input-ring-file-name
|  	(or (getenv "OCTAVE_HISTFILE") "~/.octave_hist")
| -	comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024)
| -	comint-input-filter-functions '(inferior-octave-directory-tracker))
| +	comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024))
|    (set (make-local-variable 'comint-dynamic-complete-functions)
|         inferior-octave-dynamic-complete-functions)
| +  (add-hook 'comint-input-filter-functions
| +	'inferior-octave-directory-tracker nil t)
|    (comint-read-input-ring t)
|  
|    (run-mode-hooks 'inferior-octave-mode-hook))

This patch does not apply cleanly to the octave-inf.el file that is
distributed with Octave.  I think the octave-{inf,mod,hlp}.el files
that are included with Emacs have diverged from the versions that are
distributed with Octave.  It would be helpful if someone could
reconcile the differences.  Should we even continue to distribute
these files with Octave?

Thanks,

jwe