From: "John W. Eaton" <jwe@bevo.che.wisc.edu>
To: Francesco Potorti` <pot@gnu.org>
Cc: Andreas Schwab <schwab@suse.de>,
bug-gnu-emacs@gnu.org,
Octave bugs list <bug-octave@bevo.che.wisc.edu>,
443439-maintonly@bugs.debian.org
Subject: Re: Bug#443439: emacs: run-octave captures the shell directory tracker
Date: Fri, 21 Sep 2007 11:44:14 -0400 [thread overview]
Message-ID: <18163.59086.203111.308676@segfault.lan> (raw)
In-Reply-To: <E1IYgyM-00005q-E2@tucano.isti.cnr.it>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown, Size: 1545 bytes --]
On 21-Sep-2007, Francesco Potorti` wrote:
| >This should use add-hook with LOCAL = t.
|
| Good, thanks. So here is a correct patch:
|
| 2007-09-21 Francesco Potortì <pot@gnu.org>
|
| * progmodes/octave-inf.el (inferior-octave-mode): Use add-hook to
| add inferior-octave-directory-tracker to the buffer-local value
| of comint-input-filter-functions.
|
| --- octave-inf.el 21 Sep 2007 12:19:05 +0200 1.31
| +++ octave-inf.el 21 Sep 2007 13:38:20 +0200
| @@ -153,10 +153,11 @@ Entry to this mode successively runs the
|
| (setq comint-input-ring-file-name
| (or (getenv "OCTAVE_HISTFILE") "~/.octave_hist")
| - comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024)
| - comint-input-filter-functions '(inferior-octave-directory-tracker))
| + comint-input-ring-size (or (getenv "OCTAVE_HISTSIZE") 1024))
| (set (make-local-variable 'comint-dynamic-complete-functions)
| inferior-octave-dynamic-complete-functions)
| + (add-hook 'comint-input-filter-functions
| + 'inferior-octave-directory-tracker nil t)
| (comint-read-input-ring t)
|
| (run-mode-hooks 'inferior-octave-mode-hook))
This patch does not apply cleanly to the octave-inf.el file that is
distributed with Octave. I think the octave-{inf,mod,hlp}.el files
that are included with Emacs have diverged from the versions that are
distributed with Octave. It would be helpful if someone could
reconcile the differences. Should we even continue to distribute
these files with Octave?
Thanks,
jwe
next prev parent reply other threads:[~2007-09-21 15:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 9:44 emacs: run-octave captures the shell directory tracker Francesco Potorti`
2007-09-21 10:29 ` Bug#443439: " Francesco Potorti`
2007-09-21 11:32 ` Andreas Schwab
2007-09-21 11:47 ` Francesco Potorti`
2007-09-21 15:44 ` John W. Eaton [this message]
[not found] ` <E1IYl9C-00019F-27@tucano.isti.cnr.it>
[not found] ` <je1wcs2aoy.fsf@sykes.suse.de>
2007-09-21 18:10 ` Francesco Potorti`
2007-09-21 19:29 ` Andreas Schwab
2007-09-22 11:57 ` Richard Stallman
2007-10-05 17:56 ` John W. Eaton
2007-10-06 1:52 ` Glenn Morris
2007-09-22 18:41 ` Glenn Morris
2007-09-22 20:13 ` Francesco Potorti`
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18163.59086.203111.308676@segfault.lan \
--to=jwe@bevo.che.wisc.edu \
--cc=443439-maintonly@bugs.debian.org \
--cc=bug-gnu-emacs@gnu.org \
--cc=bug-octave@bevo.che.wisc.edu \
--cc=pot@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.