all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* completion.el -- should use buffer-substring-no-properties instead of buffer-string
@ 2007-08-15  7:35 raman
  2007-08-16  1:08 ` Richard Stallman
  0 siblings, 1 reply; 4+ messages in thread
From: raman @ 2007-08-15  7:35 UTC (permalink / raw)
  To: emacs-pretest-bug

I fixed this a while ago in my local copy of Emacs and have been
using it  without any unforeseen consequences for a while, so I
thought it was time  to submit this as  a patch:

In completion.el, completions are stored to the completions file
along with text properties ---
the text properties dont achieve anything in this case. There are
a total of four instances of calls to buffer-substring in
completion.el -- I did a global replace  to use
buffer-substring-no-properties 


In GNU Emacs 22.1.50.19 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2007-08-14 on labrador
configured using `configure  '--prefix=/usr/local' '--with-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: nil

Major mode: Shell

Minor modes in effect:
  jabber-activity-mode: t
  dired-omit-mode: t
  dynamic-completion-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  display-time-mode: t
  desktop-save-mode: t
  auto-insert-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t

Recent input:
s e SPC d e f a u l t SPC h e a d e r SPC l i n e SPC 
i f SPC n o n e SPC s e t SPC t o SPC s p e a k SPC 
b u f f e r ESC DEL ESC DEL s h o w SPC b u f f e r 
SPC n a m e . " ; SPC m a k e RET C-e m C-e x v 1 RET 
ESC < C-n C-n C-n C-n C-n ESC > C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-e m C-e ESC t C-e C-w C-x 1 ESC < C-e C-w C-n 
ESC > C-p C-p C-x 4 b c a l RET C-e ESC t C-x o ESC 
[ [ C ESC [ [ C ESC [ 2 3 ~ C-x o C-e x v 1 RET C-x 
1 ESC < C-n C-n ESC > C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p ESC < C-e m C-e 
SPC ESC [ 2 3 ~ ESC [ K ESC [ 2 3 ~ c d RET c d SPC 
e m TAB l i TAB e m TAB RET ESC x l o a d SPC l i RET 
e m a c s p e a k - a d v TAB RET C-e a ESC [ K ESC 
[ L ESC [ L ESC [ L ESC [ L C-e x DEL ESC [ 2 3 ~ C-e 
m c d RET C-e m C-e m C-e m ESC x r e p o r t SPC e 
m TAB b TAB RET

Recent messages:
~ 
Loading emacsbug...done

 Thanks, 
 --Raman

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: completion.el -- should use buffer-substring-no-properties instead of buffer-string
  2007-08-15  7:35 completion.el -- should use buffer-substring-no-properties instead of buffer-string raman
@ 2007-08-16  1:08 ` Richard Stallman
  2007-08-17  7:35   ` Glenn Morris
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Stallman @ 2007-08-16  1:08 UTC (permalink / raw)
  To: emacs-pretest-bug

Does anyone see a problem with this change?

From: raman <raman@users.sf.net>
To: emacs-pretest-bug@gnu.org
From: "T. V. Raman" <raman@users.sf.net>
Date: Wed, 15 Aug 2007 00:35:05 -0700 (PDT)
Cc: 
Subject: completion.el -- should use buffer-substring-no-properties instead
	of buffer-string

I fixed this a while ago in my local copy of Emacs and have been
using it  without any unforeseen consequences for a while, so I
thought it was time  to submit this as  a patch:

In completion.el, completions are stored to the completions file
along with text properties ---
the text properties dont achieve anything in this case. There are
a total of four instances of calls to buffer-substring in
completion.el -- I did a global replace  to use
buffer-substring-no-properties 


In GNU Emacs 22.1.50.19 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2007-08-14 on labrador
configured using `configure  '--prefix=/usr/local' '--with-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: nil

Major mode: Shell

Minor modes in effect:
  jabber-activity-mode: t
  dired-omit-mode: t
  dynamic-completion-mode: t
  shell-dirtrack-mode: t
  savehist-mode: t
  display-time-mode: t
  desktop-save-mode: t
  auto-insert-mode: t
  encoded-kbd-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t

Recent input:
s e SPC d e f a u l t SPC h e a d e r SPC l i n e SPC 
i f SPC n o n e SPC s e t SPC t o SPC s p e a k SPC 
b u f f e r ESC DEL ESC DEL s h o w SPC b u f f e r 
SPC n a m e . " ; SPC m a k e RET C-e m C-e x v 1 RET 
ESC < C-n C-n C-n C-n C-n ESC > C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-e m C-e ESC t C-e C-w C-x 1 ESC < C-e C-w C-n 
ESC > C-p C-p C-x 4 b c a l RET C-e ESC t C-x o ESC 
[ [ C ESC [ [ C ESC [ 2 3 ~ C-x o C-e x v 1 RET C-x 
1 ESC < C-n C-n ESC > C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p ESC < C-e m C-e 
SPC ESC [ 2 3 ~ ESC [ K ESC [ 2 3 ~ c d RET c d SPC 
e m TAB l i TAB e m TAB RET ESC x l o a d SPC l i RET 
e m a c s p e a k - a d v TAB RET C-e a ESC [ K ESC 
[ L ESC [ L ESC [ L ESC [ L C-e x DEL ESC [ 2 3 ~ C-e 
m c d RET C-e m C-e m C-e m ESC x r e p o r t SPC e 
m TAB b TAB RET

Recent messages:
~ 
Loading emacsbug...done

 Thanks, 
 --Raman

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: completion.el -- should use buffer-substring-no-properties instead of buffer-string
  2007-08-16  1:08 ` Richard Stallman
@ 2007-08-17  7:35   ` Glenn Morris
  2007-08-17 13:37     ` T. V. Raman
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2007-08-17  7:35 UTC (permalink / raw)
  To: rms; +Cc: emacs-pretest-bug

Richard Stallman wrote:

> Does anyone see a problem with this change?

looks fine to me; installed.

> From: raman <raman@users.sf.net>
> To: emacs-pretest-bug@gnu.org
> From: "T. V. Raman" <raman@users.sf.net>
> Date: Wed, 15 Aug 2007 00:35:05 -0700 (PDT)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: completion.el -- should use buffer-substring-no-properties instead of buffer-string
  2007-08-17  7:35   ` Glenn Morris
@ 2007-08-17 13:37     ` T. V. Raman
  0 siblings, 0 replies; 4+ messages in thread
From: T. V. Raman @ 2007-08-17 13:37 UTC (permalink / raw)
  To: rgm; +Cc: emacs-pretest-bug, rms


Thanks!

>>>>> "GM" == Glenn Morris <rgm@gnu.org> writes:
    GM> Richard Stallman wrote:
    >> Does anyone see a problem with this change?
    GM> 
    GM> looks fine to me; installed.
    GM> 
    >> From: raman <raman@users.sf.net> To:
    >> emacs-pretest-bug@gnu.org From: "T. V. Raman"
    >> <raman@users.sf.net> Date: Wed, 15 Aug 2007 00:35:05 -0700
    >> (PDT)
    GM> 
    GM> 
    GM> 
    GM> _______________________________________________
    GM> Emacs-devel mailing list Emacs-devel@gnu.org
    GM> http://lists.gnu.org/mailman/listinfo/emacs-devel

-- 
Best Regards,
--raman

      
Email:  raman@users.sf.net
WWW:    http://emacspeak.sf.net/raman/
AIM:    emacspeak       GTalk: tv.raman.tv@gmail.com
PGP:    http://emacspeak.sf.net/raman/raman-almaden.asc
Google: tv+raman 
IRC:    irc://irc.freenode.net/#emacs

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-08-17 13:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-15  7:35 completion.el -- should use buffer-substring-no-properties instead of buffer-string raman
2007-08-16  1:08 ` Richard Stallman
2007-08-17  7:35   ` Glenn Morris
2007-08-17 13:37     ` T. V. Raman

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.