From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
To: rms@gnu.org
Cc: esr@snark.thyrsus.com, emacs-devel@gnu.org
Subject: Re: C-x v l does not move to current log entry
Date: Fri, 3 Aug 2007 23:08:33 -0400 [thread overview]
Message-ID: <18099.60849.120058.919034@rgrjr.dyndns.org> (raw)
In-Reply-To: <E1IGcrV-000310-Cs@fencepost.gnu.org>
[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 1696 bytes --]
From: Richard Stallman <rms@gnu.org>
Date: Thu, 02 Aug 2007 11:45:17 -0400
Would someone please DTRT and ack?
Date: Wed, 01 Aug 2007 09:51:17 +0200
From: Jan Djärv <jan.h.d@swipnet.se>
% emacs -Q src/gmalloc.c
C-x v l
The cursor stays at the top of the log view buffer.
Contrast this to emacs 22.1 where the cursor is positioned to the current
log entry for the revision of src/gmalloc.c that you are editing.
Hmm. vc-default-show-log-entry does appear to be going to the right
place, but something is messing it up afterwards. I think I'll go to
bed now and let somebody who knows what they're doing have a crack at
it. ;-}
This from *Messages* may be relevant:
Running cvs log gmalloc.c in the background... done
Loading log-view...
Loading easy-mmode...done
Loading log-view...done
Error during redisplay: (void-function ,log-view-file-re) [2 times]
This turns out to be coming from log-view-font-lock-keywords, which has
a value that looks something like this:
((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append)))
(eval \` (\,log-view-message-re . log-view-message-face)))
The source (log-view.el:170) specifies backquoted forms inside a quoted
form; it appears that the reader is not handling this correctly. The
attached patch replaces the backquotes with explicit "cons" calls; this
is not a real fix, and I include it only to show that it does make the
error messages go away. Fixing the reader is undoubtedly hairier.
However, fixing the "Error during redisplay" problem does not affect
the original symptom.
Hope this is of some use,
-- Bob Rogers
http://rgrjr.dyndns.org/
[-- Attachment #2: Type: text/plain, Size: 1286 bytes --]
Index: lisp/log-view.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/log-view.el,v
retrieving revision 1.37
diff -c -r1.37 log-view.el
*** lisp/log-view.el 23 Jun 2007 03:06:21 -0000 1.37
--- lisp/log-view.el 4 Aug 2007 02:41:52 -0000
***************
*** 170,179 ****
(defvar log-view-font-lock-keywords
;; We use `eval' so as to use the buffer-local value of log-view-file-re
;; and log-view-message-re, if applicable.
! '((eval . `(,log-view-file-re
! (1 (if (boundp 'cvs-filename-face) cvs-filename-face))
! (0 log-view-file-face append)))
! (eval . `(,log-view-message-re . log-view-message-face))))
(defconst log-view-font-lock-defaults
'(log-view-font-lock-keywords t nil nil nil))
--- 170,180 ----
(defvar log-view-font-lock-keywords
;; We use `eval' so as to use the buffer-local value of log-view-file-re
;; and log-view-message-re, if applicable.
! '((eval . (cons log-view-file-re
! '((1 (if (boundp 'cvs-filename-face) cvs-filename-face))
! (0 log-view-file-face append))))
! (eval . (cons log-view-message-re
! 'log-view-message-face))))
(defconst log-view-font-lock-defaults
'(log-view-font-lock-keywords t nil nil nil))
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-08-04 3:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 7:51 C-x v l does not move to current log entry Jan Djärv
2007-08-02 15:45 ` Richard Stallman
2007-08-04 3:08 ` Bob Rogers [this message]
2007-08-05 3:06 ` Richard Stallman
2007-08-10 8:09 ` Stefan Monnier
2007-08-12 4:15 ` Richard Stallman
2007-08-12 8:30 ` Jan Djärv
2007-08-12 22:01 ` Stefan Monnier
2007-08-13 6:03 ` Jan Djärv
2007-09-10 6:53 ` Jan Djärv
2007-09-12 8:30 ` Glenn Morris
2007-09-14 6:41 ` Jan Djärv
2007-09-15 22:25 ` Stefan Monnier
2007-09-16 8:55 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18099.60849.120058.919034@rgrjr.dyndns.org \
--to=rogers-emacs@rgrjr.dyndns.org \
--cc=emacs-devel@gnu.org \
--cc=esr@snark.thyrsus.com \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.