The annotated example of a complete working Flymake backend leaves process buffers around

The annotated example of a complete working Flymake backend leaves process buffers around

[Rudolf Adamkovič]

I noticed that the "annotated example of a complete working Flymake backend" at

<https://www.gnu.org/software/emacs/manual/html_mono/flymake.html#Backend-functions>

leaves zombie buffers around. I traced the problem down to

┌────
│ (when (eq 'exit (process-status proc)) …
└────

The backend kills the process buffer on `'exit' but not on `'signal', which happens when Flymake kills an obsolete in-progress check. I fixed the problem locally with

┌────
│ (let ((status (process-status proc)))
│   (when (or (eq status 'exit) (eq status 'signal))
│     …
└────

I think we should fix the Flymake manual as well.

Rudy
-- 
"'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and if it were so, it would be; but as it isn't, it ain't. That's logic.'" -- Lewis Carroll, Through the Looking Glass

Rudolf Adamkovič <salutis@me.com>
Studenohorská 25
84103 Bratislava
Slovakia

[he/him]

Re: The annotated example of a complete working Flymake backend leaves process buffers around

[Manuel Uberti]

On 23/10/21 09:17, Rudolf Adamkovič wrote:
> The backend kills the process buffer on `'exit' but not on `'signal', which happens when Flymake kills an obsolete in-progress check. I fixed the problem locally with
> 
> ┌────
> │ (let ((status (process-status proc)))
> │   (when (or (eq status 'exit) (eq status 'signal))
> │     …
> └────

Hi Rudolf,

thank you for this tip, I've applied it to a couple of Flymake backends I worked 
on (namely flymake-proselint and flymake-kondor).


Regards

-- 
Manuel Uberti
www.manueluberti.eu

Re: The annotated example of a complete working Flymake backend leaves process buffers around

[Stefan Kangas]

Rudolf Adamkovič <salutis@me.com> writes:

> I noticed that the "annotated example of a complete working Flymake backend" at
>
> <https://www.gnu.org/software/emacs/manual/html_mono/flymake.html#Backend-functions>
>
> leaves zombie buffers around.

Could you send this same message to bug-gnu-emacs@gnu.org so we can
track it as a bug?

Bug reports unfortunately tend to get forgotten on emacs-devel, due to
the high number of messages and lack of tracking.

Thanks in advance.

Re: The annotated example of a complete working Flymake backend leaves process buffers around

[Rudolf Adamkovič]

Stefan Kangas <stefankangas@gmail.com> writes:

> Could you send this same message to bug-gnu-emacs@gnu.org so we can
> track it as a bug?

Oops! Sorry for the noise. Opened bug#51380.

Thank you, Stefan, for you guidance.

Rudy

-- 
"Logic is a science of the necessary laws of thought, without which no employment of the understanding and the reason takes place." -- Immanuel Kant, 1785

Rudolf Adamkovič <salutis@me.com>
Studenohorská 25
84103 Bratislava
Slovakia

[he/him]

Re: The annotated example of a complete working Flymake backend leaves process buffers around

[João Távora]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Thank for finding and pinpointing this!
Please CC me in that bug report.

João

(And yes, the manual recipe probably needs fixing)

On Sun, Oct 24, 2021, 21:06 Rudolf Adamkovič <salutis@me.com> wrote:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
> > Could you send this same message to bug-gnu-emacs@gnu.org so we can
> > track it as a bug?
>
> Oops! Sorry for the noise. Opened bug#51380.
>
> Thank you, Stefan, for you guidance.
>
> Rudy
>
> --
> "Logic is a science of the necessary laws of thought, without which no
> employment of the understanding and the reason takes place." -- Immanuel
> Kant, 1785
>
> Rudolf Adamkovič <salutis@me.com>
> Studenohorská 25
> 84103 Bratislava
> Slovakia
>
> [he/him]
>
>

[-- Attachment #2: Type: text/html, Size: 1408 bytes --]