From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#60867: 29.0.60; keymap-set-after does not accept the AFTER=t argument Date: Thu, 19 Jan 2023 11:08:07 +0100 Message-ID: <17aa757a-935d-547c-b432-9529d1ed6d6b@daniel-mendler.de> References: <878ri2gx3r.fsf@daniel-mendler.de> <87r0vtaxtu.fsf@gmail.com> <3d2cc069-d258-f0b6-9679-eb13a1415202@daniel-mendler.de> <87edrsb5o3.fsf@gmail.com> <9d95e891-22ad-d700-3fab-69948a8a1a17@daniel-mendler.de> <87o7qualwa.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36789"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 60867@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 19 11:11:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIRtG-0009SG-5E for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 19 Jan 2023 11:11:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIRqx-0005qp-UC; Thu, 19 Jan 2023 05:09:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIRqw-0005qI-Ce for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pIRqw-0005ij-25 for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pIRqv-0002kc-Kd for bug-gnu-emacs@gnu.org; Thu, 19 Jan 2023 05:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Jan 2023 10:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60867 X-GNU-PR-Package: emacs Original-Received: via spool by 60867-submit@debbugs.gnu.org id=B60867.167412289810510 (code B ref 60867); Thu, 19 Jan 2023 10:09:01 +0000 Original-Received: (at 60867) by debbugs.gnu.org; 19 Jan 2023 10:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:42668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIRqD-0002jS-VX for submit@debbugs.gnu.org; Thu, 19 Jan 2023 05:08:18 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:39207 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pIRqC-0002jC-1g for 60867@debbugs.gnu.org; Thu, 19 Jan 2023 05:08:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1jnFPzl4WD/JoKFHHvKpf4rjfl6v8kh1qyy7t3w8dIc=; b=NpWNai5REYmYPz0ryAjoc3QxGb 0GwkWZxPeJILxDyQtWDZBFgAW75SJhghRgCWHu2w+mG47CEJqqSbGQYIf7KDE7XbW/mV/kC518B0Q iv4G7BEI1zxk2lrpQlJsZPhI/sh2KK16HGGuV2BjriSFGOEvWS7vTkclzA1M6ua3sB+M=; Content-Language: en-US In-Reply-To: <87o7qualwa.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253690 Archived-At: On 1/19/23 10:55, Robert Pluim wrote: > And of course the following for consistency for `keymap-lookup' as > well. I now firmly believe that the new keymap functions should use > `key-parse' and not `kbd'. Robert, speaking of `key-parse', I wonder why this function accepts invalid key strings. Why don't we move the `key-valid-p' check to `key-parse'? This would alleviate the need for many additional `key-valid-p' checks across keymap.el. One could maybe even get rid of the `keymap--check' helper. The function `key-parse' is publicly exposed to the user and as such it would be good if it were as strict as the rest of the keymap.el API. However `kbd' has been reimplemented based on `key-parse' which prevents `key-parse' from being more strict. One could either introduce a `key--parse-lax` function which is used by `kbd' and `key-parse' (plus a `key-valid-p' check) or add a NOERROR/NOVALIDATE argument to `key-parse', which is then used by `kbd'. What do you think? > Eli, is this too much for emacs-29? While it is late for 29, these APIs were newly and I believe it would be better to improve them now, such that they don't have to change again in the next release. Daniel