all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Alexandru Harsanyi <harsanyi@mac.com>
To: Eric S. Raymond <esr@snark.thyrsus.com>
Cc: emacs-devel@gnu.org
Subject: Re: Introducing 'unrecognized and 'ignored
Date: Sat, 29 Dec 2007 11:48:58 +0900	[thread overview]
Message-ID: <17EA38DF-BCC1-4565-8510-5DD10DD667E3@mac.com> (raw)
In-Reply-To: <20071228174512.66834830BC9@snark.thyrsus.com>


On 29 Dec 2007, at 2:45 AM, Eric S. Raymond wrote:

> I've spent the last couple of hours looking at this issue.
> A reminder: the payoff for getting it right would be another
> significant speedup in (vc-dired-hook), which would translate to
> a faster C-x v d display.
>
> Remarkably, it looks as if the code does not actually depend
> in any significant way on the nil return from (vc-state file) meaning
> that FILE is unregistered.  Tests that might have used this method
> use vc-backend instead.  So introducing an 'unregistered state
> shouldn't actually break anything.
>
> Alex Harsanyi: A cvs-ignorable-file-p would actually be useful, if
> you're still interested. Under later systems it's faster to get this
> by doing a bit of estra parsing of rge status report.
>

I had a look at the problem last night and wrote the code to load a  
cvsignore file and produce a regexp to match the ignored files,  
however the whole mechanism required by `vc-BACKEND-ignorable-file-p'  
is quite tricky to implement corectly (in a way that both Emacs and  
the backend agree 100% on what files are ignored).  Here are two of  
the problems I found when I looked at an implementation for CVS:

  * CVS will ignore a file only if it is unregistered.  For  
example .o files are ignored from a CVS status listing, but if an .o  
file is registered than that file will show up in the listing.  This  
requires checking whether a file is registered or not, a thing which  
we try to avoid.

  * There's a 'per-repository' cvsignore file at $CVSROOT/CVSROOT/ 
cvsignore which Emacs cannot access directly for remote repositories.


With extended vc-state states I don't think there is a need for `vc- 
ignorable-file-p' at all:  `vc-BACKEND-dir-state' should set the  
state for each registered file and for files it can register.  `vc- 
dired-hook' can than simply look for the vc-state property and if it  
is missing it can assume that the file is ignored.

Best Regards,
Alex.

  parent reply	other threads:[~2007-12-29  2:48 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 17:45 Introducing 'unrecognized and 'ignored Eric S. Raymond
2007-12-28 23:01 ` Dan Nicolaescu
2007-12-29  2:48 ` Alexandru Harsanyi [this message]
2007-12-29 11:45   ` Eric S. Raymond
2008-01-02  2:02     ` Stefan Monnier
2008-01-02  2:19       ` Eric S. Raymond
2008-01-02  4:16         ` Stefan Monnier
2008-01-02  4:45           ` Dan Nicolaescu
2008-01-02 11:50             ` Eric S. Raymond
2008-01-02 17:31               ` Dan Nicolaescu
2008-01-03  9:50             ` Richard Stallman
2008-01-03 18:05               ` Dan Nicolaescu
2008-01-03 18:19                 ` Eric S. Raymond
2008-01-05  5:54                 ` Richard Stallman
2008-01-05  9:01                   ` Dan Nicolaescu
2008-01-05 14:34                     ` Eric S. Raymond
2008-01-05 22:25                       ` Stefan Monnier
2008-01-06 10:37                       ` Dan Nicolaescu
2008-01-06 15:57                         ` Eric S. Raymond
2008-01-18 23:31                           ` Dan Nicolaescu
2008-01-06 20:00                         ` Tom Tromey
2008-01-06 21:03                           ` Stefan Monnier
2008-01-07  2:59                             ` Dan Nicolaescu
2008-01-07  3:26                               ` Eric S. Raymond
2008-01-07  3:36                                 ` Dan Nicolaescu
2008-01-07  3:59                                 ` Stefan Monnier
2008-01-07 12:56                                   ` Eric S. Raymond
2008-01-07 15:31                                     ` Stefan Monnier
2008-01-07 11:30                                 ` Richard Stallman
2008-01-07 12:54                                   ` Eric S. Raymond
2008-01-07 15:32                                     ` Stefan Monnier
2008-01-08 19:06                                     ` Richard Stallman
2008-01-08 19:34                                       ` Miles Bader
2008-01-07  3:22                           ` Dan Nicolaescu
2008-01-07  3:03                             ` Tom Tromey
2008-01-07  4:01                               ` Stefan Monnier
2008-01-07 21:15                                 ` PCL-CVS buffers (was: Introducing 'unrecognized and 'ignored) Reiner Steib
2008-01-08  2:33                                   ` PCL-CVS buffers Stefan Monnier
2008-01-18 23:46                           ` Introducing 'unrecognized and 'ignored Dan Nicolaescu
2008-01-19  0:10                             ` Tom Tromey
2008-01-19  1:20                               ` Dan Nicolaescu
2008-01-19  6:00                             ` Tom Tromey
2008-01-19 17:05                               ` Dan Nicolaescu
2008-01-19 19:40                                 ` Stefan Monnier
2008-01-19 21:01                                   ` Thien-Thi Nguyen
2008-01-20 17:18                                     ` Dan Nicolaescu
2008-01-20 20:24                                       ` Thien-Thi Nguyen
2008-01-20 17:08                                   ` Dan Nicolaescu
2008-01-20 19:08                                   ` Tom Tromey
2008-01-20 20:14                                     ` Stefan Monnier
2008-01-20 19:45                                       ` Tom Tromey
2008-01-22  1:35                                         ` Dan Nicolaescu
2008-01-19 20:03                                 ` Thien-Thi Nguyen
2008-01-20 19:24                                   ` Stefan Monnier
2008-01-20 20:30                                     ` Thien-Thi Nguyen
2008-01-21 15:18                                       ` Stefan Monnier
2008-01-21 15:30                                         ` Dan Nicolaescu
2008-01-21 15:56                                           ` Stefan Monnier
2008-01-21 15:34                                         ` Thien-Thi Nguyen
2008-01-06  8:09                     ` Richard Stallman
2008-01-02 11:46           ` Eric S. Raymond
2008-01-02 20:38             ` Stefan Monnier
2008-01-02 22:11               ` Eric S. Raymond
2008-01-02 23:06                 ` Stefan Monnier
2008-01-02 23:29                   ` Eric S. Raymond
2008-01-03 14:30                     ` Stefan Monnier
2008-01-03 17:41                       ` Eric S. Raymond
2008-01-05  5:54                         ` Richard Stallman
2008-01-02 23:13                 ` Dan Nicolaescu
2008-01-02 23:33                   ` Eric S. Raymond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17EA38DF-BCC1-4565-8510-5DD10DD667E3@mac.com \
    --to=harsanyi@mac.com \
    --cc=emacs-devel@gnu.org \
    --cc=esr@snark.thyrsus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.