From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: tool-bars - broken again Date: Sat, 3 Jul 2010 12:23:34 -0700 Message-ID: <17A106BDF5AA40A9B41416AE7E8F13CB@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1278185076 8032 80.91.229.12 (3 Jul 2010 19:24:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 3 Jul 2010 19:24:36 +0000 (UTC) To: "'Emacs-Devel devel'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 03 21:24:35 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OV8KI-0007CK-M8 for ged-emacs-devel@m.gmane.org; Sat, 03 Jul 2010 21:24:35 +0200 Original-Received: from localhost ([127.0.0.1]:39338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OV8KI-0004jK-2h for ged-emacs-devel@m.gmane.org; Sat, 03 Jul 2010 15:24:34 -0400 Original-Received: from [140.186.70.92] (port=36787 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OV8KB-0004jC-VI for emacs-devel@gnu.org; Sat, 03 Jul 2010 15:24:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OV8KA-0007Rt-Hj for emacs-devel@gnu.org; Sat, 03 Jul 2010 15:24:27 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:45063) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OV8KA-0007RB-CM for emacs-devel@gnu.org; Sat, 03 Jul 2010 15:24:26 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o63JOLVM019879 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 3 Jul 2010 19:24:23 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o63J87uh001350 for ; Sat, 3 Jul 2010 19:24:21 GMT Original-Received: from abhmt012.oracle.com by acsmt355.oracle.com with ESMTP id 394635541278185011; Sat, 03 Jul 2010 12:23:31 -0700 Original-Received: from dradamslap1 (/141.144.160.41) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 03 Jul 2010 12:23:31 -0700 X-Priority: 1 (Highest) X-MSMail-Priority: High X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acsa5Trl1iXYoM2hT9u+DvS7NqOAbg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Importance: High X-Message-Flag: Follow up X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A0B0203.4C2F8E65.01BD:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126736 Archived-At: The latest Windows binary I have, from 6/28, breaks tool bars again. GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-06-28 on 3249CTO I see no problem with the previous Windows binary, from 6/21 (or prior). I must say, and I am trying to be polite, that I am really getting tired of the fiddling with the tool bars that has been going on for years now. I try to have code that works across versions. You just won't leave it alone, it seems. I'm sorry, but I cannot narrow this down better - I do not have a simple recipe. In my startup code, I set `default-frame-alist' and I also turn off `tool-bar-mode'. Prior to the 6/28 build, the value of `tool-bar-lines' in `default-frame-alist' was correctly set to 0 when my code turned off `tool-bar-mode'; now it is not. I don't know whether it was Yidong's recent change for bug #2249 that broke things or whether it was changes to `tool-bar.el' during the same week (6/21-6/28) that broke things - or whether those are in fact the same thing. (BZR by HTTP is down, as usual ("Please try again..."), so I cannot track the changes further. I do not have the time for that anyway. http://bazaar.launchpad.net/~vcs-imports/emacs/trunk/files/head%3A/lisp/) This is the diff I see in tool-bar.el, that I think might be relevant. 6/28 build ---------- :init-value t (let ((val (if tool-bar-mode 1 0))) (dolist (frame (frame-list)) (set-frame-parameter frame 'tool-bar-lines val))) (when tool-bar-mode (if (= 1 (length (default-value 'tool-bar-map))) ; not yet setup (tool-bar-setup)))) 6/21 build and prior -------------------- :init-value nil (if tool-bar-mode (progn (modify-all-frames-parameters (list (cons 'tool-bar-lines 1))) (if (= 1 (length (default-value 'tool-bar-map))) ; not yet setup (tool-bar-setup))) (modify-all-frames-parameters (list (cons 'tool-bar-lines 0)))) (put 'tool-bar-mode 'standard-value '(t)) The big difference I see (but I'm no expert on this and I will not try to dig deeper) is that previously we called `modify-all-frames-parameters', which sets the `tool-bar-lines' setting also in `default-frames-alist' (and in `initial-frame-alist'). Now we apparently set `tool-bar-lines' only for the existing frames. That alone might explain the breakage. I have no idea whether changing the :init-value and removing the `standard-value' setting might have something to do with the breakage. Whatever the cause, the result is that although my startup code calls `tool-bar-mode' to turn off the tool bar, all new frames (including the first frame) are created with a tool bar. Please, please fix this. I spent hours today trying to figure out what's going on (in my code), to no avail. Please do not ask me to try to narrow things further - I just don't have the time for this. Thanks.