From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Fri, 18 May 2007 10:29:37 +1200 Message-ID: <17996.55121.658525.561979@kahikatea.snap.net.nz> References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> <17995.53754.860573.633945@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1179440994 11867 80.91.229.12 (17 May 2007 22:29:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 22:29:54 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 18 00:29:51 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HooTl-0001lr-Ny for ged-emacs-devel@m.gmane.org; Fri, 18 May 2007 00:29:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hoobu-00036A-17 for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 18:38:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hoobq-00035g-LP for emacs-devel@gnu.org; Thu, 17 May 2007 18:38:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hoobp-00035P-Ba for emacs-devel@gnu.org; Thu, 17 May 2007 18:38:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hoobp-00035M-77 for emacs-devel@gnu.org; Thu, 17 May 2007 18:38:09 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HooTe-0001Mt-Lf; Thu, 17 May 2007 18:29:43 -0400 Original-Received: from kahikatea.snap.net.nz (148.60.255.123.dynamic.snap.net.nz [123.255.60.148]) by viper.snap.net.nz (Postfix) with ESMTP id 0B36C3D98FD; Fri, 18 May 2007 10:29:40 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 4F39C8F92B; Fri, 18 May 2007 10:29:38 +1200 (NZST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.1.50.251 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71282 Archived-At: > > Well it means changes to write_glyphs and rif->write_glyphs in a dozen or > > so places in dispnew.c, and a change to x_write_glyph in xdisp.c at least > > (and perhaps w32con_write_glyphs). If you're comfortable with those > > changes and still think it's the right approach, I'll do that. > > It doesn't seem like it'd be a big problem as such. The problem is that it takes me to code that I don't really understand. > But I do wonder why > this is necessary now, even though it hasn't been necessary until now for > all other places where we support mouse highlighting. So a bit of > argumentation that explains why this situation is different seems in order. > It might also help understand the code, so I'd recommend to put it > in comments. As Eli says, xdisp.c uses draw_glyphs which is actually much more complicated. I only intend to comment the code that I add because that's all I really understand, i.e., I can't make comments about the difference with draw_glyphs. -- Nick http://www.inet.net.nz/~nickrob