From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Thu, 17 May 2007 15:54:34 +1200 Message-ID: <17995.53754.860573.633945@kahikatea.snap.net.nz> References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1179374107 18025 80.91.229.12 (17 May 2007 03:55:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 03:55:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 05:55:04 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HoX4x-0006H9-IS for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 05:55:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoXD0-0001IY-B2 for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 00:03:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HoXCx-0001IM-0d for emacs-devel@gnu.org; Thu, 17 May 2007 00:03:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HoXCw-0001IA-GR for emacs-devel@gnu.org; Thu, 17 May 2007 00:03:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoXCw-0001I7-Aa for emacs-devel@gnu.org; Thu, 17 May 2007 00:03:18 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HoX4q-0001o5-UY; Wed, 16 May 2007 23:54:57 -0400 Original-Received: from kahikatea.snap.net.nz (150.62.255.123.dynamic.snap.net.nz [123.255.62.150]) by viper.snap.net.nz (Postfix) with ESMTP id ADDA33D808A; Thu, 17 May 2007 15:54:43 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 94CA58F92B; Thu, 17 May 2007 15:54:35 +1200 (NZST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.1.50.251 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71209 Archived-At: > > I can't easily add an extra argument to write_glyphs as it's called in many > > places. > > But it sounds like all of them but one should be called with that > argument zero, so it shouldn't be too hard to convert them. Am I > missing something? Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and perhaps w32con_write_glyphs). If you're comfortable with those changes and still think it's the right approach, I'll do that. > > Do you mean something like below? (I've tested it and it works too.) > > It's certainly more lightweght, but I think global variables tend to spoil > > the flow. > > Yes, that's what I had in mind. But isn't it equivalent to calling > write_glyphs with the additional flag argument non-zero in just this > one place? That would eliminate the need for a global variable. Yes, I think they're equivalent. -- Nick http://www.inet.net.nz/~nickrob