From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Console based mouse face highlighting. Date: Sun, 13 May 2007 16:19:05 +1200 Message-ID: <17990.37305.657724.344516@kahikatea.snap.net.nz> References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1179029963 27772 80.91.229.12 (13 May 2007 04:19:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 13 May 2007 04:19:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 13 06:19:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hn5YG-0004uf-GV for ged-emacs-devel@m.gmane.org; Sun, 13 May 2007 06:19:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hn5fr-0005ex-SC for ged-emacs-devel@m.gmane.org; Sun, 13 May 2007 00:27:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hn5fo-0005ei-B9 for emacs-devel@gnu.org; Sun, 13 May 2007 00:27:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hn5fm-0005eW-TW for emacs-devel@gnu.org; Sun, 13 May 2007 00:27:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hn5fm-0005eT-Me for emacs-devel@gnu.org; Sun, 13 May 2007 00:27:06 -0400 Original-Received: from viper.snap.net.nz ([202.37.101.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hn5Y8-0000E9-TU; Sun, 13 May 2007 00:19:13 -0400 Original-Received: from kahikatea.snap.net.nz (55.61.255.123.dynamic.snap.net.nz [123.255.61.55]) by viper.snap.net.nz (Postfix) with ESMTP id EB1A03D9287; Sun, 13 May 2007 16:19:09 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 1000) id 5D57E8F92B; Sun, 13 May 2007 16:19:06 +1200 (NZST) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.1.50.175 X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70947 Archived-At: > > OK, thanks, that helped. I've now replaced calls to x_y_to_hpos_vpos with > > code in that file. It looks a bit better now, but the mouse highlighting > > is from text adjacent to the pointer, appears in a slightly different > > location and only when there is some input e.g a mouse click, and remains > > until I do a refresh (^L). > > I'm afraid I don't quite understand what you are saying here. What do > you mean by ``mouse highlighting is from text adjacent to the > pointer''? can you show an image or describe this with a specific > example? Also, in what ``slightly different location'' does the > highlight appear? I dont know how to make a screenshot on a text terminal but I'll try to explain more clearly. In dired with something like -rw-r--r-- 1 nickrob nickrob 22289 2007-04-23 05:00 abbrev.c -rw-r--r-- 1 nickrob nickrob 185308 2007-05-09 23:02 abbrev.o -rw-r--r-- 1 nickrob nickrob 1311 2007-02-11 11:34 acldef.h -rw-r--r-- 1 nickrob nickrob 14768 2004-01-31 06:10 alloca.c The filenames have mouse face highlighting. If I click on acldef.h, then the text "alloca.c" might appear after abbrev.c, say, with the mouse face overlay (green background, black foreground). If I click on other filenames, I get similar output (sometimes more than one filename). These all accumulate until I do ^L, when they disappear. Perhaps some of my glyph row/column calculations are a bit wrong. > > 1) Does write_glyphs *overwrite* existing glyphs (while insert_glyphs adds > > to them) ? > > Yes (on both accounts). More accurately, write_glyphs simply dumps > the glyphs to the screen (with a call to fwrite), which on a tty will > overwrite whatever is displayed in the respective screen locations, > while insert_glyphs first switches the screen to insert mode, and then > calls write_glyphs. > > > It would be nice if a comment said what these functions do. > > Feel free to add comments. Personally, I think the code speaks very > well for itself (I didn't write it), but that's me. It probably speaks for itself if you are generally familiar with terminal control. I'll add comments when I have a better understanding. > > 2) After a call to write_glyphs, does the cursor position move? > > I'm not sure. Why is this important? Anyway, Emacs always > repositions the cursor at point at redisplay end. I've not considered the cursor up till now and it sometimes seems to jump around (but perhaps I'm confusing the cursor with the pointer, which are the same shape with Gpm). > > 3) Any hints on frame updating ? (both xterm.c and msdos.c use dpyinfo) > > Sorry, I don't understand the question. Please elaborate. I'll explore further. -- Nick http://www.inet.net.nz/~nickrob