From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.devel Subject: Another issue with thingatpt Date: Wed, 27 Dec 2006 15:29:02 -0500 Message-ID: <17810.55182.483602.421178@rgrjr.dyndns.org> References: <003001c727be$349c5a80$0203a8c0@HomeNetbbb0> <20061225.094150.13771816.wl@gnu.org> <20061227.115042.56977126.wl@gnu.org> NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1167251368 25870 80.91.229.10 (27 Dec 2006 20:29:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 27 Dec 2006 20:29:28 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 27 21:29:25 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GzfOs-0006nx-9e for ged-emacs-devel@m.gmane.org; Wed, 27 Dec 2006 21:29:22 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzfOr-0005Ej-Ml for ged-emacs-devel@m.gmane.org; Wed, 27 Dec 2006 15:29:21 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GzfOc-0005EW-EI for emacs-devel@gnu.org; Wed, 27 Dec 2006 15:29:06 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GzfOZ-0005DA-HU for emacs-devel@gnu.org; Wed, 27 Dec 2006 15:29:04 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzfOZ-0005D3-B4 for emacs-devel@gnu.org; Wed, 27 Dec 2006 15:29:03 -0500 Original-Received: from [24.128.218.106] (helo=rgrjr.dyndns.org) by monty-python.gnu.org with smtp (Exim 4.52) id 1GzfOY-0002vs-Uf for emacs-devel@gnu.org; Wed, 27 Dec 2006 15:29:03 -0500 Original-Received: (qmail 31066 invoked by uid 500); 27 Dec 2006 20:29:02 -0000 Original-To: Werner LEMBERG In-Reply-To: <20061227.115042.56977126.wl@gnu.org> X-Mailer: VM 7.19 under Emacs 22.0.91.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64368 Archived-At: From: Werner LEMBERG Date: Wed, 27 Dec 2006 11:50:42 +0100 (CET) Here's another problematic URL: http://mousai.kanji.zinbun.kyoto-u.ac.jp/ids-find?components=&U+20207; thingatpt ignores the final `;'. Werner According to RFC3986 (aka STD066), this is wrong; ";" is legitimate anywhere in a path or query part, including the end. So are "." and ",", but thing-at-point-url-path-regexp also refuses to match these characters at the end of the string. Doing (ffap-string-at-point 'url) drops these characters plus ":", "!", and (questionably) "?". It may not be possible to find a tradeoff between RFC compliance and parsing dwimmery that would satisfy everybody. Since stripping off trailing punctuation is useful behavior (ISTR it's worked this way for a while now), I would recommend against changing it now. However, a case could be made for making thing-at-point and ffap-string-at-point consistent. Perhaps "!:;.," would be best? This is just the union of the two sets but without the dubious inclusion of "?". -- Bob Rogers http://rgrjr.dyndns.org/