From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
Cc: emacs-devel@gnu.org
Subject: Another issue with thingatpt
Date: Wed, 27 Dec 2006 15:29:02 -0500 [thread overview]
Message-ID: <17810.55182.483602.421178@rgrjr.dyndns.org> (raw)
In-Reply-To: <20061227.115042.56977126.wl@gnu.org>
From: Werner LEMBERG <wl@gnu.org>
Date: Wed, 27 Dec 2006 11:50:42 +0100 (CET)
Here's another problematic URL:
http://mousai.kanji.zinbun.kyoto-u.ac.jp/ids-find?components=&U+20207;
thingatpt ignores the final `;'.
Werner
According to RFC3986 (aka STD066), this is wrong; ";" is legitimate
anywhere in a path or query part, including the end. So are "." and
",", but thing-at-point-url-path-regexp also refuses to match these
characters at the end of the string. Doing (ffap-string-at-point 'url)
drops these characters plus ":", "!", and (questionably) "?".
It may not be possible to find a tradeoff between RFC compliance and
parsing dwimmery that would satisfy everybody. Since stripping off
trailing punctuation is useful behavior (ISTR it's worked this way for a
while now), I would recommend against changing it now. However, a case
could be made for making thing-at-point and ffap-string-at-point
consistent. Perhaps "!:;.," would be best? This is just the union of
the two sets but without the dubious inclusion of "?".
-- Bob Rogers
http://rgrjr.dyndns.org/
next prev parent reply other threads:[~2006-12-27 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <003001c727be$349c5a80$0203a8c0@HomeNetbbb0>
[not found] ` <20061225.094150.13771816.wl@gnu.org>
[not found] ` <htx7iwdn717.fsf@urania.kanji.zinbun.kyoto-u.ac.jp>
2006-12-27 10:50 ` Another issue with thingatpt Werner LEMBERG
2006-12-27 20:29 ` Bob Rogers [this message]
2006-12-28 6:39 ` Werner LEMBERG
2006-12-29 21:23 ` Piet van Oostrum
2006-12-31 3:08 ` Bob Rogers
2006-12-31 9:25 ` Andreas Roehler
2006-12-31 17:24 ` Bob Rogers
2007-01-02 13:34 ` Andreas Roehler
2007-01-03 14:50 ` Andreas Roehler
2006-12-31 20:07 ` Piet van Oostrum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17810.55182.483602.421178@rgrjr.dyndns.org \
--to=rogers-emacs@rgrjr.dyndns.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.