From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: string-to-char Date: Tue, 28 Nov 2006 08:32:34 +1300 Message-ID: <17771.15699.17292.735995@kahikatea.snap.net.nz> References: <456AB507.1060808@gmx.at> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164658216 22853 80.91.229.2 (27 Nov 2006 20:10:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2006 20:10:16 +0000 (UTC) Cc: martin rudalics , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 27 21:10:13 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gommb-0000Fx-Ud for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 21:08:54 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gommb-00027J-Fk for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 15:08:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GomLB-0003St-Hr for emacs-devel@gnu.org; Mon, 27 Nov 2006 14:40:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GomL6-0003OI-BI for emacs-devel@gnu.org; Mon, 27 Nov 2006 14:40:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GomL4-0003N1-Sc for emacs-devel@gnu.org; Mon, 27 Nov 2006 14:40:27 -0500 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GomHa-0005Io-MN for emacs-devel@gnu.org; Mon, 27 Nov 2006 14:36:51 -0500 Original-Received: from kahikatea.snap.net.nz (p202-124-120-125.snap.net.nz [202.124.120.125]) by viper.snap.net.nz (Postfix) with ESMTP id ABAAE3D83AA; Tue, 28 Nov 2006 08:37:34 +1300 (NZDT) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 9D3D9BE44A; Tue, 28 Nov 2006 08:32:36 +1300 (NZDT) Original-To: "Juanma Barranquero" In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.91.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62881 Archived-At: > And some of those uses are quite weird, BTW: > > - In erc/erc.el: > (separator (make-string erc-fill-column (string-to-char "="))) > (make-string (length x) (string-to-char "b")) > > - In progmodes/fortran.el: > (or (equal char (string-to-char " ")) > > Aren't these redundant? (I don't think the unibyte/multibyte issue is > relevant in any of them...) Very probably. The problem with changing them and the large numbers of files to which you are applying trivial fixes is that the code being pretested is no longer that in the repository. I think it's best to follow the adage: "If it ain't broke then don't fix it.". At least, until After The Release (TM). -- Nick http://www.inet.net.nz/~nickrob