From: Nick Roberts <nickrob@snap.net.nz>
Cc: martin rudalics <rudalics@gmx.at>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: string-to-char
Date: Tue, 28 Nov 2006 08:32:34 +1300 [thread overview]
Message-ID: <17771.15699.17292.735995@kahikatea.snap.net.nz> (raw)
In-Reply-To: <f7ccd24b0611270252h61c24c15r47ea8a1051a04d33@mail.gmail.com>
> And some of those uses are quite weird, BTW:
>
> - In erc/erc.el:
> (separator (make-string erc-fill-column (string-to-char "=")))
> (make-string (length x) (string-to-char "b"))
>
> - In progmodes/fortran.el:
> (or (equal char (string-to-char " "))
>
> Aren't these redundant? (I don't think the unibyte/multibyte issue is
> relevant in any of them...)
Very probably. The problem with changing them and the large numbers of files
to which you are applying trivial fixes is that the code being pretested is no
longer that in the repository. I think it's best to follow the adage: "If it
ain't broke then don't fix it.". At least, until After The Release (TM).
--
Nick http://www.inet.net.nz/~nickrob
next prev parent reply other threads:[~2006-11-27 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 9:51 string-to-char martin rudalics
2006-11-27 10:52 ` string-to-char Juanma Barranquero
2006-11-27 19:32 ` Nick Roberts [this message]
2006-11-27 20:13 ` string-to-char Juanma Barranquero
2006-11-27 20:59 ` string-to-char Nick Roberts
2006-11-29 3:28 ` string-to-char Richard Stallman
2006-11-29 9:09 ` string-to-char Juanma Barranquero
2006-11-30 3:20 ` string-to-char Richard Stallman
2006-11-27 23:43 ` string-to-char Richard Stallman
2006-11-28 0:36 ` string-to-char Glenn Morris
2006-11-27 13:38 ` string-to-char Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17771.15699.17292.735995@kahikatea.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.