From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bob Rogers Newsgroups: gmane.emacs.devel Subject: Re: Add more URI schemes to thing-at-point-uri-schemes. Date: Sun, 19 Nov 2006 17:21:16 -0500 Message-ID: <17760.55516.982498.893710@rgrjr.dyndns.org> References: <87psbkpj3p.fsf@x3y2z1.net> <17760.51342.599312.481360@rgrjr.dyndns.org> <85slgf9m00.fsf@lola.goethe.zz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1163974915 20834 80.91.229.2 (19 Nov 2006 22:21:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 19 Nov 2006 22:21:55 +0000 (UTC) Cc: Diane Murray , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 19 23:21:52 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Glv2r-0006Io-Ko for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2006 23:21:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Glv2q-0008Eg-Vt for ged-emacs-devel@m.gmane.org; Sun, 19 Nov 2006 17:21:49 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Glv2S-0008DB-GJ for emacs-devel@gnu.org; Sun, 19 Nov 2006 17:21:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Glv2Q-0008C1-HO for emacs-devel@gnu.org; Sun, 19 Nov 2006 17:21:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Glv2Q-0008Bt-FC for emacs-devel@gnu.org; Sun, 19 Nov 2006 17:21:22 -0500 Original-Received: from [24.128.218.106] (helo=rgrjr.dyndns.org) by monty-python.gnu.org with smtp (Exim 4.52) id 1Glv2L-00026s-RN for emacs-devel@gnu.org; Sun, 19 Nov 2006 17:21:19 -0500 Original-Received: (qmail 27932 invoked by uid 500); 19 Nov 2006 22:21:17 -0000 Original-To: David Kastrup In-Reply-To: <85slgf9m00.fsf@lola.goethe.zz> X-Mailer: VM 7.19 under Emacs 22.0.90.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62507 Archived-At: From: David Kastrup Date: Sun, 19 Nov 2006 22:15:11 +0100 Bob Rogers writes: > This does fix the problem, but the "irc:" URL is currently being matched > by thing-at-point-short-url-regexp in thing-at-point-url-at-point, which > subsequently attaches the "http://" prefix. The attached patch avoids > prefixing one scheme with another, which is incorrect regardless of how > many schemes `thing-at-point-uri-schemes' knows about (and is therefore > independent of your patch). What does it do with file:///C:/windows or something similar? If "file:///C:/windows" is what's under point in the buffer, then that string is exactly what is returned. This case not affected by the posted patch, because "file:/" is a known scheme, so the thing-at-point-short-url-regexp path is not taken, -- Bob