From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: AriT93 Newsgroups: gmane.emacs.devel Subject: Re: Fwd: vc-svn.el and "the underscore hack" Date: Wed, 1 Nov 2006 15:02:18 -0600 Message-ID: <17737.2906.943000.448790@gargle.gargle.HOWL> References: <17735.25691.286000.488074@gargle.gargle.HOWL> Reply-To: AriT93 NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1162414977 15883 80.91.229.2 (1 Nov 2006 21:02:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Nov 2006 21:02:57 +0000 (UTC) Cc: Stefan Monnier , spiegel@gnu.org, rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 01 22:02:54 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GfNET-00019e-Lm for ged-emacs-devel@m.gmane.org; Wed, 01 Nov 2006 22:02:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GfNET-0002rb-Am for ged-emacs-devel@m.gmane.org; Wed, 01 Nov 2006 16:02:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GfNEJ-0002rM-Lt for emacs-devel@gnu.org; Wed, 01 Nov 2006 16:02:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GfNEH-0002qt-Uq for emacs-devel@gnu.org; Wed, 01 Nov 2006 16:02:35 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GfNEH-0002qq-RH for emacs-devel@gnu.org; Wed, 01 Nov 2006 16:02:33 -0500 Original-Received: from [138.87.130.210] (helo=syssrv30.ad.ilstu.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GfNDj-000526-G9; Wed, 01 Nov 2006 16:01:59 -0500 Original-Received: from SYS270307 ([138.87.130.16]) by syssrv30.ad.ilstu.edu with Microsoft SMTPSVC(6.0.3790.211); Wed, 1 Nov 2006 15:02:21 -0600 Original-To: emacs-devel@gnu.org In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.90.1 X-OriginalArrivalTime: 01 Nov 2006 21:02:21.0003 (UTC) FILETIME=[05A521B0:01C6FDF9] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61574 Archived-At: Stefan Monnier writes: >--snip--< > > As mentioned elsewhere the ".foo -> _foo" transformation is not specific to > Subversion and/or Emacs, so I think we should not handle it specially in > vc-svn.el but instead in a more generic way, maybe directly in the C code or > at least by providing a function that handles it. > > > Stefan Thank you for your reply. I am unclear on where else it was mentioned about the transformation, it is possible I missed a reply. I was not aware that vc-svn.el interacted with any subversion specific functions in the C code. From reading through vc-svn.el it appeared to just call the svn executable for any svn functions. The change that I had proposed mostly just made sure that vc-svn.el was aware of this possibility, since not checking for the _svn directory would cause it to incorrectly assume that files were not under subversion control. So this would not be a case of .foo -> _foo but specifically .svn -> _svn. I'm not trying to be argumentative and appreciate your response. -- enjoy every sandwich -- W. Zevon