From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c Date: Sat, 19 Jan 2019 13:53:26 -0800 Organization: UCLA Computer Science Department Message-ID: <176c3ec3-7c6a-8f89-b31c-66c8cd129339@cs.ucla.edu> References: <20190119182259.26893.32117@vcs0.savannah.gnu.org> <20190119182301.0DE562043D@vcs0.savannah.gnu.org> <034912a4e687ae39bfc17b45ec6a9ef7.squirrel@dancol.org> <4508562eb2e3fe5fedd01263f6c39d5c.squirrel@dancol.org> NNTP-Posting-Host: ciao.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ciao.gmane.org 1547934868 138081 195.159.176.228 (19 Jan 2019 21:54:28 GMT) X-Complaints-To: usenet@ciao.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2019 21:54:28 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 19 22:54:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1gkyZN-000ZtZ-1J for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 22:54:25 +0100 Original-Received: from localhost ([127.0.0.1]:60268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyZW-0000YF-4f for ged-emacs-devel@m.gmane.org; Sat, 19 Jan 2019 16:54:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkyYf-0000Xp-FB for emacs-devel@gnu.org; Sat, 19 Jan 2019 16:53:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkyYd-0000ls-Ux for emacs-devel@gnu.org; Sat, 19 Jan 2019 16:53:41 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60980) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gkyYc-0000c0-4O for emacs-devel@gnu.org; Sat, 19 Jan 2019 16:53:38 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 270661610E4; Sat, 19 Jan 2019 13:53:28 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Aeq79j_ARbb4; Sat, 19 Jan 2019 13:53:27 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 31E2A1610E6; Sat, 19 Jan 2019 13:53:27 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2FtTVw2aQhdH; Sat, 19 Jan 2019 13:53:27 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 07AD4160FE8; Sat, 19 Jan 2019 13:53:27 -0800 (PST) In-Reply-To: <4508562eb2e3fe5fedd01263f6c39d5c.squirrel@dancol.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232502 Archived-At: Daniel Colascione wrote: > Ah, never mind. I saw the constants at the end of the patch and jumped the > gun. While we're on the subject, why does pdumper-stats return milliseconds? Returning seconds would be simpler, and the number is a float so I don't see the point of picking some other unit of measure.