From: Nick Dokos <nick@gamaville.dokosmarshall.org>
To: Thomas Baumann <dtbaumann@yahoo.de>
Cc: mh-e-users@lists.sourceforge.net, emacs-orgmode@gnu.org
Subject: Re: Re: Bug fix: org-mhe links don't work with mairix
Date: Sat, 17 May 2008 16:23:22 -0400 [thread overview]
Message-ID: <17623.1211055802@gamaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Thomas Baumann <dtbaumann@yahoo.de> of "Sat, 17 May 2008 17:15:41 +0200." <m3r6c12c82.fsf@norvel.baumann-gauting.site>
Thomas Baumann <dtbaumann@yahoo.de> wrote:
> Hi Nick,
>
> your patch actually breaks namazu, swish and grep searches.
>
> A look at mh-search-choices (mh-search.el) reveals that for namazu,
> swish and grep mh-search-regexp-builder is nil and therefore
>
> (funcall mh-search-regexp-builder ...
>
> raises an error. One might be tempted to solve this on the mh-e side but
> there's no reason to add a mh-search-regexp-builder for those search
> engines. There's a patch against todays git below.
>
> BTW. Namazu and pick searches work fine without angular brackets, however, it
> doesn't harm to have them.
>
>
> Greetings
> Thomas
>
Thomas,
Yes indeed: sorry for the breakage and thanks for coming up with a
fix. I agree that it's preferable to change the call site rather than
asking for changes to mh-e.
Thanks very much,
Nick
PS. For the record, the patch against mh-e that I sent earlier to both
the mh-e and org lists has also been submitted on the mh-e sourceforge
patches list at
http://sourceforge.net/tracker/?group_id=13357&atid=313357
It's number 1965704.
>
> --- /data/cvs/org-mode/lisp/org-mhe.el 2008-05-17 12:54:07.000000000 +0200
> +++ org-mhe.el 2008-05-17 16:55:22.000000000 +0200
> @@ -204,8 +204,10 @@
> (not (org-mhe-get-message-real-folder)))
> (kill-this-buffer)
> (mh-search "+" (list "--message-id" article))))
> - (mh-search "+" (funcall mh-search-regexp-builder
> - (list (cons 'message-id article)))))
> + (if mh-search-regexp-builder
> + (mh-search "+" (funcall mh-search-regexp-builder
> + (list (cons 'message-id article))))
> + (mh-search "+" article)))
> (if (org-mhe-get-message-real-folder)
> (mh-show-msg 1)
> (kill-this-buffer)
>
--45B245DFCA.1211054880/gamaville.dokosmarshall.org--
next prev parent reply other threads:[~2008-05-17 20:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 3:31 Bug fix: org-mhe links don't work with mairix Nick Dokos
2008-05-16 14:27 ` Carsten Dominik
2008-05-17 15:15 ` Thomas Baumann
2008-05-17 20:23 ` Nick Dokos [this message]
2008-05-17 21:17 ` Bill Wohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17623.1211055802@gamaville.dokosmarshall.org \
--to=nick@gamaville.dokosmarshall.org \
--cc=dtbaumann@yahoo.de \
--cc=emacs-orgmode@gnu.org \
--cc=mh-e-users@lists.sourceforge.net \
--cc=nicholas.dokos@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.