From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: C-g crash redux Date: Sat, 5 Aug 2006 10:07:37 +1200 Message-ID: <17619.50473.875843.483875@kahikatea.snap.net.nz> References: <877j1qvp4k.fsf@pacem.orebokech.com> <17617.8764.824445.882539@kahikatea.snap.net.nz> <87fygd97j0.fsf@stupidchicken.com> <87zmelfihg.fsf@stupidchicken.com> <877j1owmhx.fsf@stupidchicken.com> <874pwsebes.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1154729381 8062 80.91.229.2 (4 Aug 2006 22:09:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2006 22:09:41 +0000 (UTC) Cc: Romain Francoise , emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 05 00:09:38 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G97rG-0001cF-73 for ged-emacs-devel@m.gmane.org; Sat, 05 Aug 2006 00:09:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G97rF-0002nj-Lz for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2006 18:09:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G97r2-0002mw-Ut for emacs-devel@gnu.org; Fri, 04 Aug 2006 18:09:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G97r1-0002mk-AX for emacs-devel@gnu.org; Fri, 04 Aug 2006 18:09:16 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G97r1-0002mh-7y for emacs-devel@gnu.org; Fri, 04 Aug 2006 18:09:15 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G97uf-000531-AV for emacs-devel@gnu.org; Fri, 04 Aug 2006 18:13:01 -0400 Original-Received: from kahikatea.snap.net.nz (p202-124-124-7.snap.net.nz [202.124.124.7]) by viper.snap.net.nz (Postfix) with ESMTP id EE9B577FC13; Sat, 5 Aug 2006 10:09:11 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 8E6BBBE3AA; Sat, 5 Aug 2006 10:07:39 +1200 (NZST) Original-To: Chong Yidong In-Reply-To: <874pwsebes.fsf@stupidchicken.com> X-Mailer: VM 7.19 under Emacs 22.0.50.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:58107 Archived-At: > The previous code suggestion I gave was not well thought out. The > correct way to implement this is as follows. I've checked that with > this change, the addition of wait_reading_process_output_unwind does > not cause a crash when C-g is done during sit-for. > > Do you think this is the right approach? >... It looks good to my inexperienced eye, but Emacs seems to go for a long time before hitting Fsignal. I wonder if Fsignal resets other things that might not add up in the interim period but I don't know what the rules are for placing the QUIT macro or whether one could be placed closer to read_char. -- Nick http://www.inet.net.nz/~nickrob