* allout.el patch - fixes for some edge conditions
@ 2006-07-14 20:05 Ken Manheimer
2006-07-15 4:35 ` Nick Roberts
0 siblings, 1 reply; 2+ messages in thread
From: Ken Manheimer @ 2006-07-14 20:05 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
i have a few more patches for obscure allout bugs.
two rectify things in my previous patch - one fixes a docstring
grammar error, and the other fixes the new allout-hotspot-key-handler
so it can be used consistently for other purposes than allout's
standard pre-command bullet hotspot operation.
the two other changes fix two other, old bugs having to do with
beginning-of-buffer edge conditions.
below is the ChangeLog entry. the patch is attached.
2006-07-14 Ken Manheimer <ken.manheimer@gmail.com>
* allout.el: (allout-run-unit-tests-on-load): Rectified docstring
grammar.
(allout-beginning-of-current-line): Beware beginning of buffer.
Also, a comment is simplified.
(allout-hotspot-key-handler): Only set allout-post-goto-bullet when
appropriate. (This fix enables use for other than bullet-hotspot
operation.)
(allout-hide-current-subtree): While escalating to sibling-close,
make sure to situate on a topic.
--
ken
ken.manheimer@gmail.com
http://myriadicity.net
[-- Attachment #2: allout-patch.txt --]
[-- Type: text/plain, Size: 2159 bytes --]
Index: allout.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/allout.el,v
retrieving revision 1.78
diff -u -u -r1.78 allout.el
--- allout.el 14 Jul 2006 11:24:56 -0000 1.78
+++ allout.el 14 Jul 2006 19:25:01 -0000
@@ -580,8 +580,8 @@
Generally, allout code developers are the only ones who'll want to set this.
\(If set, this makes it an even better practice to exercise changes by
-doing byte-compilation with a repeat count, so the file is loaded at the
-of compilation.)
+doing byte-compilation with a repeat count, so the file is loaded after
+compilation.)
See `allout-run-unit-tests' to see what's run."
:type 'boolean
@@ -2022,13 +2022,11 @@
(defun allout-beginning-of-current-line ()
"Like beginning of line, but to visible text."
- ;; XXX We would use `(move-beginning-of-line 1)', but it gets
- ;; stuck on some hidden newlines, eg at column 80, as of GNU Emacs 22.0.50.
- ;; Conversely, `beginning-of-line' can make no progress in other
- ;; situations. Both are necessary, in the order used below.
+ ;; This combination of move-beginning-of-line and beginning-of-line is
+ ;; deliberate, but the (beginning-of-line) may now be superfluous.
(move-beginning-of-line 1)
(beginning-of-line)
- (while (or (not (bolp)) (allout-hidden-p))
+ (while (and (not (bobp)) (or (not (bolp)) (allout-hidden-p)))
(beginning-of-line)
(if (or (allout-hidden-p) (not (bolp)))
(forward-char -1))))
@@ -2757,8 +2755,7 @@
(lookup-key mapped-binding (read-key-sequence-vector nil t))))
(if mapped-binding
- (setq allout-post-goto-bullet on-bullet
- this-command mapped-binding)))))
+ (setq this-command mapped-binding)))))
;;;_ > allout-find-file-hook ()
(defun allout-find-file-hook ()
@@ -4087,6 +4084,7 @@
((allout-up-current-level 1 t) (allout-hide-current-subtree))
(t (goto-char 0)
(message sibs-msg)
+ (allout-goto-prefix)
(allout-expose-topic '(0 :))
(message (concat sibs-msg " Done."))))
(goto-char from)))
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: allout.el patch - fixes for some edge conditions
2006-07-14 20:05 allout.el patch - fixes for some edge conditions Ken Manheimer
@ 2006-07-15 4:35 ` Nick Roberts
0 siblings, 0 replies; 2+ messages in thread
From: Nick Roberts @ 2006-07-15 4:35 UTC (permalink / raw)
Cc: Emacs-Devel
I've comitted your changes (I think this was a request: ISTR earlier e-mails
were). In any case, it would clearly make sense you to have write access.
I committed everything verbatim for convenience, but a few picky things about
ChangeLog entries:
2006-07-14 Ken Manheimer <ken.manheimer@gmail.com>
* allout.el: (allout-run-unit-tests-on-load): Rectified docstring
^ ^^^^^^^^^
This colon is not needed. Present tense should be used.
(C-x 4 a does it automatically in Emacs)
grammar.
(allout-beginning-of-current-line): Beware beginning of buffer.
Also, a comment is simplified.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Simplify comment.
(allout-hotspot-key-handler): Only set allout-post-goto-bullet when
appropriate. (This fix enables use for other than bullet-hotspot
operation.)
Just say what you have done in the ChangeLog (and maybe why you have done it
in the code).
(allout-hide-current-subtree): While escalating to sibling-close,
make sure to situate on a topic.
--
Nick http://www.inet.net.nz/~nickrob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-15 4:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-14 20:05 allout.el patch - fixes for some edge conditions Ken Manheimer
2006-07-15 4:35 ` Nick Roberts
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.