From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: allout.el patch - fixes for some edge conditions Date: Sat, 15 Jul 2006 16:35:48 +1200 Message-ID: <17592.28836.646108.83909@kahikatea.snap.net.nz> References: <2cd46e7f0607141305r9c7526bt19dd91ada22cc310@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1152938252 15766 80.91.229.2 (15 Jul 2006 04:37:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 15 Jul 2006 04:37:32 +0000 (UTC) Cc: Emacs-Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 15 06:37:28 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G1bu3-0006fq-MD for ged-emacs-devel@m.gmane.org; Sat, 15 Jul 2006 06:37:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G1bu3-0006WC-6a for ged-emacs-devel@m.gmane.org; Sat, 15 Jul 2006 00:37:19 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1G1btr-0006UU-O3 for emacs-devel@gnu.org; Sat, 15 Jul 2006 00:37:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1G1btp-0006SN-R0 for emacs-devel@gnu.org; Sat, 15 Jul 2006 00:37:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1G1btp-0006SC-Oz for emacs-devel@gnu.org; Sat, 15 Jul 2006 00:37:05 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1G1bvy-00053f-2p for emacs-devel@gnu.org; Sat, 15 Jul 2006 00:39:18 -0400 Original-Received: from kahikatea.snap.net.nz (p202-124-112-127.snap.net.nz [202.124.112.127]) by viper.snap.net.nz (Postfix) with ESMTP id 8AC0D7765A4; Sat, 15 Jul 2006 16:37:02 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 5A8C91D3550; Sat, 15 Jul 2006 16:35:49 +1200 (NZST) Original-To: "Ken Manheimer" In-Reply-To: <2cd46e7f0607141305r9c7526bt19dd91ada22cc310@mail.gmail.com> X-Mailer: VM 7.19 under Emacs 22.0.50.37 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:57033 Archived-At: I've comitted your changes (I think this was a request: ISTR earlier e-mails were). In any case, it would clearly make sense you to have write access. I committed everything verbatim for convenience, but a few picky things about ChangeLog entries: 2006-07-14 Ken Manheimer * allout.el: (allout-run-unit-tests-on-load): Rectified docstring ^ ^^^^^^^^^ This colon is not needed. Present tense should be used. (C-x 4 a does it automatically in Emacs) grammar. (allout-beginning-of-current-line): Beware beginning of buffer. Also, a comment is simplified. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Simplify comment. (allout-hotspot-key-handler): Only set allout-post-goto-bullet when appropriate. (This fix enables use for other than bullet-hotspot operation.) Just say what you have done in the ChangeLog (and maybe why you have done it in the code). (allout-hide-current-subtree): While escalating to sibling-close, make sure to situate on a topic. -- Nick http://www.inet.net.nz/~nickrob