From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: comint-insert-input on non-command lines: A trivial fix, a quibble, and a bug Date: Tue, 9 May 2006 15:11:33 +1200 Message-ID: <17504.2149.496291.186794@farnswood.snap.net.nz> References: <17501.373.791079.156322@rgrjr.dyndns.org> <17502.37204.411491.461843@farnswood.snap.net.nz> <200605080349.k483neE2027538@jane.dms.auburn.edu> <200605080408.k4848t65027552@jane.dms.auburn.edu> <17502.50834.303952.808659@farnswood.snap.net.nz> <17503.63124.518985.734399@rgrjr.dyndns.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1147144362 30766 80.91.229.2 (9 May 2006 03:12:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 May 2006 03:12:42 +0000 (UTC) Cc: emacs-devel@gnu.org, Luc Teirlinck , Miles Bader Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 09 05:12:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FdIeJ-00057E-DC for ged-emacs-devel@m.gmane.org; Tue, 09 May 2006 05:12:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FdIeI-0007Tr-Ha for ged-emacs-devel@m.gmane.org; Mon, 08 May 2006 23:12:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FdIe5-0007Tb-GA for emacs-devel@gnu.org; Mon, 08 May 2006 23:12:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FdIe2-0007TP-HQ for emacs-devel@gnu.org; Mon, 08 May 2006 23:12:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FdIe2-0007TM-Cj for emacs-devel@gnu.org; Mon, 08 May 2006 23:12:18 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FdIex-0002U4-27; Mon, 08 May 2006 23:13:15 -0400 Original-Received: from farnswood.snap.net.nz (p202-124-114-33.snap.net.nz [202.124.114.33]) by viper.snap.net.nz (Postfix) with ESMTP id 98AA1756073; Tue, 9 May 2006 15:12:12 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 500) id 41125627ED; Tue, 9 May 2006 04:11:34 +0100 (BST) Original-To: Bob Rogers In-Reply-To: <17503.63124.518985.734399@rgrjr.dyndns.org> X-Mailer: VM 7.19 under Emacs 22.0.50.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54121 Archived-At: > There is also a comment by comint-use-prompt-regexp (also present in > 21.3): > > ;; Note: If it is decided to purge comint-prompt-regexp from the source > ;; entirely, searching for uses of this variable will help to identify > ;; places that need attention. > > I presume use of comint-prompt-regexp preceded the use of fields. > Perhaps this should be purged as there's no need to use two methods and > this would reduce the maintenance overhead. > > Perhaps, but that doesn't address the original issue, namely that in > comint-mode "C-c RET" is now less useful that it had been. You're quoting my reply to Luc. My reply to you, which you appear to have ignored, did address the original issue. > From: Miles Bader > Date: Mon, 08 May 2006 13:49:19 +0900 > > Luc Teirlinck writes: > > BTW, that function's use of fields is not well written. > > Also, it uses `posn-set-point' _after_ getting the value of (point), > which doesn't make any sense to me. > > The following seems to fix both problems . . . > > I'll commit this unless somebody objects. > > But it doesn't address the original problem: "C-c RET" still does > nothing when invoked on an output line. Please find a solution below > that merges your changes with the guts of the comint-copy-old-input > definition from 21.3, restoring the original behavior. If that is > satisfactory to everyone, then I will undertake to ensure that all of > the documentation is consistent. I've already said why I don't like it. We haven't reached an agreement yet that this behaviour is desirable. -- Nick http://www.inet.net.nz/~nickrob