From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Display feature request: gud-overlay-arrow Date: Tue, 21 Mar 2006 15:55:53 +1200 Message-ID: <17439.31049.393782.938907@kahikatea.snap.net.nz> References: <17439.13250.269939.241145@kahikatea.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1143480368 22823 80.91.229.2 (27 Mar 2006 17:26:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Mar 2006 17:26:08 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 27 19:26:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FNvTC-0007zD-E6 for ged-emacs-devel@m.gmane.org; Mon, 27 Mar 2006 19:25:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FNvTB-0001ZK-Pg for ged-emacs-devel@m.gmane.org; Mon, 27 Mar 2006 12:25:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FLY04-000184-9M for emacs-devel@gnu.org; Mon, 20 Mar 2006 22:57:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FLY03-00017s-10 for emacs-devel@gnu.org; Mon, 20 Mar 2006 22:57:39 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLY02-00017p-Sn for emacs-devel@gnu.org; Mon, 20 Mar 2006 22:57:38 -0500 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FLY01-0003jE-AT for emacs-devel@gnu.org; Mon, 20 Mar 2006 22:57:38 -0500 Original-Received: from kahikatea.snap.net.nz (p202-124-115-133.snap.net.nz [202.124.115.133]) by viper.snap.net.nz (Postfix) with ESMTP id 9630974A2C3; Tue, 21 Mar 2006 15:57:22 +1200 (NZST) Original-Received: by kahikatea.snap.net.nz (Postfix, from userid 500) id 03CE488ED; Tue, 21 Mar 2006 15:55:54 +1200 (NZST) Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: X-Mailer: VM 7.19 under Emacs 22.0.50.85 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:52093 Archived-At: > Can't you do that via the fringe-indicator-alist variable ? Yes. > I guess it would be easier to do if we had a "post-switch-buffer-hook" that > is called (after post-command-hook) whenever a new buffer is selected > in the command loop. No, the variable fringe-indicator-alist works fine (for my purpose anyway), I just wasn't familiar with it. Is it OK to commit the patch below? It includes some minor corrections to the doco. -- Nick http://www.inet.net.nz/~nickrob 2006-03-21 Nick Roberts * fringe.c (short hollow_right_triangle_bits) New bitmap. (standard_bitmaps): Add it to the list. 2006-03-21 Nick Roberts * fringe.el: Add hollow-right-triangle to the list of standard bitmaps. 2006-03-21 Nick Roberts * display.texi (Fringe Indicators): Add hollow-right-triangle to the list of standard bitmaps. Correct typos. *** fringe.c 16 Mar 2006 09:42:25 +1300 1.40 --- fringe.c 21 Mar 2006 15:43:44 +1200 *************** static unsigned short left_triangle_bits *** 242,247 **** --- 242,261 ---- static unsigned short right_triangle_bits[] = { 0xc0, 0xf0, 0xf8, 0xfc, 0xfc, 0xf8, 0xf0, 0xc0}; + /* Hollow triangular arrow. */ + /* + xxx..... + x..x.... + x...x... + x....x.. + x....x.. + x...x... + x..x.... + xxx..... + */ + static unsigned short hollow_right_triangle_bits[] = { + 0xe0, 0x90, 0x88, 0x84, 0x84, 0x88, 0x90, 0xe0}; + /* First line bitmap. An top-left angle. */ /* xxxxxx.. *************** static unsigned short empty_line_bits[] *** 451,478 **** struct fringe_bitmap standard_bitmaps[] = { { NULL, 0, 0, 0, 0, 0 }, /* NO_FRINGE_BITMAP */ ! { FRBITS (question_mark_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (left_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (up_arrow_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (down_arrow_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (left_curly_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_curly_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (left_triangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_triangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (top_left_angle_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (top_right_angle_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (bottom_left_angle_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (bottom_right_angle_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (left_bracket_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_bracket_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (filled_rectangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (hollow_rectangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (filled_square_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (hollow_square_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (vertical_bar_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (horizontal_bar_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (empty_line_bits), 8, 3, ALIGN_BITMAP_TOP, 0 }, }; #define NO_FRINGE_BITMAP 0 --- 465,493 ---- struct fringe_bitmap standard_bitmaps[] = { { NULL, 0, 0, 0, 0, 0 }, /* NO_FRINGE_BITMAP */ ! { FRBITS (question_mark_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (left_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (up_arrow_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (down_arrow_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (left_curly_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_curly_arrow_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (left_triangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_triangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (hollow_right_triangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (top_left_angle_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (top_right_angle_bits), 8, 0, ALIGN_BITMAP_TOP, 0 }, ! { FRBITS (bottom_left_angle_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (bottom_right_angle_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (left_bracket_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (right_bracket_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (filled_rectangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (hollow_rectangle_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (filled_square_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (hollow_square_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (vertical_bar_bits), 8, 0, ALIGN_BITMAP_CENTER, 0 }, ! { FRBITS (horizontal_bar_bits), 8, 0, ALIGN_BITMAP_BOTTOM, 0 }, ! { FRBITS (empty_line_bits), 8, 3, ALIGN_BITMAP_TOP, 0 }, }; #define NO_FRINGE_BITMAP 0 *** fringe.el 22 Feb 2006 14:42:39 +1300 1.27 --- fringe.el 21 Mar 2006 15:34:07 +1200 *************** *** 47,53 **** (let ((bitmaps '(question-mark left-arrow right-arrow up-arrow down-arrow left-curly-arrow right-curly-arrow ! left-triangle right-triangle top-left-angle top-right-angle bottom-left-angle bottom-right-angle left-bracket right-bracket --- 47,53 ---- (let ((bitmaps '(question-mark left-arrow right-arrow up-arrow down-arrow left-curly-arrow right-curly-arrow ! left-triangle right-triangle hollow-right-triangle top-left-angle top-right-angle bottom-left-angle bottom-right-angle left-bracket right-bracket *** display.texi 17 Mar 2006 11:37:48 +1300 1.211 --- display.texi 21 Mar 2006 15:27:53 +1200 *************** used in both left and right fringes. *** 2876,2887 **** When @code{fringe-indicator-alist} has a buffer-local value, and there is no bitmap defined for a logical indicator, or the bitmap is @code{t}, the corresponding value from the (non-local) ! @code{default-fringes-indicator-alist} is used. To completely hide a specific indicator, set the bitmap to @code{nil}. @end defvar ! @defvar default-fringes-indicator-alist The value of this variable is the default value for @code{fringe-indicator-alist} in buffers that do not override it. @end defvar --- 2876,2887 ---- When @code{fringe-indicator-alist} has a buffer-local value, and there is no bitmap defined for a logical indicator, or the bitmap is @code{t}, the corresponding value from the (non-local) ! @code{default-fringe-indicator-alist} is used. To completely hide a specific indicator, set the bitmap to @code{nil}. @end defvar ! @defvar default-fringe-indicator-alist The value of this variable is the default value for @code{fringe-indicator-alist} in buffers that do not override it. @end defvar *************** The value of this variable is the defaul *** 2890,2897 **** @item Standard fringe bitmaps for indicators: @code{left-arrow}, @code{right-arrow}, @code{up-arrow}, @code{down-arrow}, @code{left-curly-arrow}, @code{right-curly-arrow}, ! @code{left-triangle}, @code{right-triangle}, ! @code{top-left-angle}, @code{ top-right-angle}, @code{bottom-left-angle}, @code{bottom-right-angle}, @code{left-bracket}, @code{right-bracket}, @code{filled-rectangle}, @code{hollow-rectangle}, --- 2890,2897 ---- @item Standard fringe bitmaps for indicators: @code{left-arrow}, @code{right-arrow}, @code{up-arrow}, @code{down-arrow}, @code{left-curly-arrow}, @code{right-curly-arrow}, ! @code{left-triangle}, @code{right-triangle}, @code{hollow-right-triangle}, ! @code{top-left-angle}, @code{top-right-angle}, @code{bottom-left-angle}, @code{bottom-right-angle}, @code{left-bracket}, @code{right-bracket}, @code{filled-rectangle}, @code{hollow-rectangle},