Patch: blue underlined for button face and fill in apropos

* Patch: blue underlined for button face and fill in apropos
@ 2006-02-18 22:40 Lennart Borgman
  2006-02-19  0:29 ` Nick Roberts
  2006-02-19 17:17 ` Juri Linkov
  0 siblings, 2 replies; 5+ messages in thread
From: Lennart Borgman @ 2006-02-18 22:40 UTC (permalink / raw)

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Here are some small patches I have not had time to propose before. The 
first one changes the color to blue for `button' face. This is the 
underlined face used in help.

I have suggested this before, but without sending a patch.

The second patch sets the default for `apropos-label-face' to `button' 
(above). It also adds filling of of values in the list shown by M-x 
apropos. I believe this makes the list more readable.

[-- Attachment #2: button-blue.patch --]
[-- Type: text/plain, Size: 835 bytes --]

Index: lisp/button.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/button.el,v
retrieving revision 1.21
diff -c -r1.21 button.el
*** lisp/button.el	6 Feb 2006 14:33:32 -0000	1.21
--- lisp/button.el	18 Feb 2006 22:30:37 -0000
***************
*** 54,60 ****
  ;; Use color for the MS-DOS port because it doesn't support underline.
  (defface button '((((type pc) (class color))
  		   (:foreground "lightblue"))
! 		  (t :underline t))
    "Default face used for buttons."
    :group 'basic-faces)

--- 54,60 ----
  ;; Use color for the MS-DOS port because it doesn't support underline.
  (defface button '((((type pc) (class color))
  		   (:foreground "lightblue"))
! 		  (t :underline t :foreground "blue"))
    "Default face used for buttons."
    :group 'basic-faces)

[-- Attachment #3: apropos-button-and-fill.patch --]
[-- Type: text/plain, Size: 2133 bytes --]

Index: lisp/apropos.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/apropos.el,v
retrieving revision 1.114
diff -c -r1.114 apropos.el
*** lisp/apropos.el	6 Feb 2006 14:33:31 -0000	1.114
--- lisp/apropos.el	18 Feb 2006 22:33:04 -0000
***************
*** 85,91 ****
    :group 'apropos
    :type 'face)

! (defcustom apropos-label-face 'italic
    "*Face for label (`Command', `Variable' ...) in Apropos output.
  A value of nil means don't use any special font for them, and also
  turns off mouse highlighting."
--- 85,91 ----
    :group 'apropos
    :type 'face)

! (defcustom apropos-label-face 'button
    "*Face for label (`Command', `Variable' ...) in Apropos output.
  A value of nil means don't use any special font for them, and also
  turns off mouse highlighting."
***************
*** 980,994 ****
    (if (stringp (setq i (nth i apropos-item)))
        (progn
  	(insert "  ")
! 	(insert-text-button (button-type-get type 'apropos-label)
! 			    'type type
! 			    ;; Can't use the default button face, since
! 			    ;; user may have changed the variable!
! 			    ;; Just say `no' to variables containing faces!
! 			    'face apropos-label-face
! 			    'apropos-symbol (car apropos-item))
! 	(insert ": ")
! 	(insert (if do-keys (substitute-command-keys i) i))
  	(or (bolp) (terpri)))))

--- 980,996 ----
    (if (stringp (setq i (nth i apropos-item)))
        (progn
  	(insert "  ")
!         (let ((start (point)))
!           (insert-text-button (button-type-get type 'apropos-label)
!                               'type type
!                               ;; Can't use the default button face, since
!                               ;; user may have changed the variable!
!                               ;; Just say `no' to variables containing faces!
!                               'face apropos-label-face
!                               'apropos-symbol (car apropos-item))
!           (insert ": ")
!           (insert (if do-keys (substitute-command-keys i) i))
!           (fill-region start (point)))
  	(or (bolp) (terpri)))))

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread