From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Harald =?UTF-8?Q?J=C3=B6rg?= Newsgroups: gmane.emacs.bugs Subject: bug#22867: cperl-mode: Commit d0ad6306 suppresses fontification of hash/array declarations Date: Tue, 1 Sep 2020 21:44:02 +0200 Message-ID: <1738df57-6707-a08d-80a2-c581808dbaef@posteo.de> References: <87ziui3d2f.fsf@jidanni.org> <793881bc-c77d-8ddd-61b2-d20d94107eed@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 To: Stefan Kangas , 22867@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 01 21:45:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kDCDO-0006Vf-0M for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 21:45:10 +0200 Original-Received: from localhost ([::1]:50578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDCDN-00006Q-3B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Sep 2020 15:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDCDG-00006I-7G for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 15:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45859) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDCDF-0008GT-Ta for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 15:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kDCDF-0001It-Kz for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2020 15:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Harald =?UTF-8?Q?J=C3=B6rg?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Sep 2020 19:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22867-submit@debbugs.gnu.org id=B22867.15989894534943 (code B ref 22867); Tue, 01 Sep 2020 19:45:01 +0000 Original-Received: (at 22867) by debbugs.gnu.org; 1 Sep 2020 19:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:57405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDCCS-0001He-13 for submit@debbugs.gnu.org; Tue, 01 Sep 2020 15:44:12 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:60801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kDCCP-0001HQ-UI for 22867@debbugs.gnu.org; Tue, 01 Sep 2020 15:44:10 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 5D6772400FD for <22867@debbugs.gnu.org>; Tue, 1 Sep 2020 21:44:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1598989443; bh=B13NkKLE4w9V4IEBvWxcMtIdW1+GU7JNW8jG9KRnNQQ=; h=Subject:To:From:Autocrypt:Date:From; b=NmZ5RsI18ykJxs2AB46ti8guocpi28161u9Xkc4fYyWhaR4uAW0JQmWYzpvymw+tq JQpJn2zGx+Dj135Shautpcz0irCHYtMpOAxx+L8gKIdWg92qcCAbY2SXbsosIujWgU 75rb9kRyW1euUsBs+k8T9F9bSNCzBcW0MaYmAgEgpUBxdbZ8jxqKy1WnPH5xb2eYFR ZZHOUiq689hAuZdRAClIGzXD5pfyF4J9jqnTOcRgEzqntKDGYlJz+cVYQ6L4f4JNOc 0KLz6u9kkWgD58tkzw6gdebBB3r0WkX0ZVgSegMkQxxUlkp7mAW3C73KRF7Yj35ZkI N+jX7nqOMFMSA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BgyDy6FLxz9rxb; Tue, 1 Sep 2020 21:44:02 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186887 Archived-At: On 9/1/20 6:34 PM, Stefan Kangas wrote: > forcemerge 11054 22867 > thanks > > Harald Jörg writes: > >> The recent fix d0ad6306 to cperl-mode fixes a lot of unwanted >> fontification of arrays and hashes, in particular in comments, POD, >> and strings. However, as a side effect it also prevents fontification >> in a variable declaration (this has been observed by choroba): > > It would be very nice to have test cases for all this. Indeed. That will take a while, too :) Not too long ago I stumbled over (or was pointed to?) a suite https://github.com/Lindydancer/font-lock-regression-suite which also contains an example in Perl. Testing this example against its faceup-counterpart would fail as of today. > Is the fix worse than the problem? If yes, maybe it should be reverted? The fix isn't _worse_. Strings like "%s" and "%d" in the argument list of printf being fontified as hashes is indeed idiotic. Also, more than once I was annoyed by fontification in POD sections. On the other hand, declarations of hashes and arrays occur rather frequently, and there's a lot more in that area that would deserve some love and care. So, while this fix was a necessary first step in any case, some refinement might be desirable to cut off the rough edges it left. I don't see an easy way, but this might be well due to my limited elisp experience. -- Cheers, haj