bug#24574: emacs-module is not GPL compatible (Windows)

[Mambo Levis <mambo.levis@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1811 bytes --]

Hi,
Yes, in summary there is no bug after all, yes you can close it.
Recommendations for windows users:

Problem 1: "The module is not GPL compatible". My suggestion is to provide a more generic Makefile able to link external libraries such Sqlite. Attached you can find the final version of the Makefile I used to build the module. Another recommendation is to test if DLL symbols are exported using tools such pexports or Dependecy walker. 
Problem 2: "The emacs module can't be found". This is easy to handle by adding the path to sqlite3.dll to windows environment variables. Other solution is put the sqlite3.dll in the same folder where the emacs.exe is located. In case that someone add the path to sqlite3.dll in emacs init file, it should be located before calling the emacs module. In my case, I move my windows path setup in emacsto the top of the init file.
I think the most important was the support I receive from you, thank you.
Levis

 

    On Wednesday, October 5, 2016 4:48 AM, "npostavs@users.sourceforge.net" <npostavs@users.sourceforge.net> wrote:
 

 Mambo Levis <mambo.levis@gmail.com> writes:

> Please, notice that this time the plugin_is_GPL_compatible. The
> problem is now that the module can't be found when a sqlite3.dll
> symbol is used.

What was the difference between this time and the previous time?

>
> The only thing left to do was to put sqlite.dll in the emacs\bin
> folder and Voilà, now it works. In fact I had already added the path
> and used to sqlite3.dll in my emacs init file, but the location was
> wrong; after my emacs-modules collection.

So there is no bug after all?  Should we just close this report, or is
there perhaps some guidance we should add to the documentation about how
to build modules on Windows?

   

[-- Attachment #1.2: Type: text/html, Size: 4521 bytes --]

[-- Attachment #2: Makefile --]
[-- Type: application/octet-stream, Size: 1404 bytes --]

# Makefile V3

# Test GNU Emacs modules.

# Copyright 2015-2016 Free Software Foundation, Inc.

# This file is part of GNU Emacs.

# GNU Emacs is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.

# GNU Emacs is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License
# along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.

EMACS = D:\user\emacs-src\emacs-25-branch-src
INCLUDE = -I. -I$(CURDIR)\src -I$(EMACS)\src -I$(CURDIR)\lib
LIB = $(CURDIR)\lib

CC      = gcc
LD      = gcc
LDFLAGS = 

# On MS-Windows, say "make SO=dll" to build the module
SO      = dll
# -fPIC is a no-op on Windows, but causes a compiler warning
ifeq ($(SO),dll)
CFLAGS  = -std=gnu99 -ggdb3 
else
CFLAGS  = -std=gnu99 -ggdb3 -fPIC
endif

all: sqlite3-core.$(SO)

%.$(SO): %.o
	$(LD) -shared $(LDFLAGS) -o $@ $< $(LIB)\sqlite3.lib

%.o: %.c
	$(CC) $(CFLAGS) $(INCLUDE) -c $<

check:
	$(EMACS)/src/emacs -batch -l ert -l test.el -f ert-run-tests-batch-and-exit
    
clean:
	rm -rf *.o *.dll *.a *.d