From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43892: [PATCH] Native comp: fix compilation warnings Date: Mon, 12 Oct 2020 19:40:22 +0200 (CEST) Message-ID: <1710269652.302891.1602524422518@ichabod.co-bxl> References: <306152990.137422.1602282958454@ichabod.co-bxl> <1749446071.142449.1602292798440@ichabod.co-bxl> Reply-To: Brian Leung , Brian Leung Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_302631_47977201.1602524237268" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38117"; mail-complaints-to="usenet@ciao.gmane.io" To: akrl@sdf.org, 43892@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 12 19:41:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kS1os-0009om-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Oct 2020 19:41:10 +0200 Original-Received: from localhost ([::1]:50718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1or-0005r3-Oy for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Oct 2020 13:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1ok-0005qZ-1d for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1oj-0006te-P6 for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:41:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kS1oj-00050e-NT for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Oct 2020 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Andrea Corallo , "Brian Leung via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\"" X-Debbugs-Original-Cc: 43892@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160252443919219 (code B ref -1); Mon, 12 Oct 2020 17:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Oct 2020 17:40:39 +0000 Original-Received: from localhost ([127.0.0.1]:43909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS1oM-0004zu-Iy for submit@debbugs.gnu.org; Mon, 12 Oct 2020 13:40:38 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS1oH-0004zb-W2 for submit@debbugs.gnu.org; Mon, 12 Oct 2020 13:40:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1oH-0005pE-Ot for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:40:33 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:55194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1oE-0006je-7E for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 13:40:33 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id D9B9EE53; Mon, 12 Oct 2020 19:40:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1602524425; bh=7VPNtx8sOV/ftb4Dp10NpL1pYluwetz4qmDHQvDe/0U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From; b=DfBRiuso2EZc6VnXE7NBdOuTwrJvY10gBeY+/qa5E2HjoZUDGjhSvkxEnUy7dcBXL bmB2IEGcrwYQ0QJfaGDDaoS0BXyoG+5Fz/yBOhZBVl+OzMvAPbE4EZSHThC3hxVUcE e18lk18LsYvJvRmpRb4SF4r4oyCok026/CkhO6kjsBbZiXEtXvbsxslYx4V2ceR/AK Y4A+RKEKhqrbrct1i6coLtMyopgSGG0hlWk27wSJU4BQ5rxllWADq8KbqKy1gLphh7 XNl8m3P7nYq1mXRgOhPrt2tuT3TSItEZTFuGJbeZPnywnl23FVbm90u2Pk8qI84jr/ K6FT6vGg6Ztuw== In-Reply-To: X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 Received-SPF: pass client-ip=212.3.242.68; envelope-from=leungbk@mailfence.com; helo=wilbur.contactoffice.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/12 13:40:26 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190350 Archived-At: ------=_Part_302631_47977201.1602524237268 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Andrea, I have rebased the patch and attached. I looked at the CONTRIBUTE file, whi= ch says that minor commits with "; " in front do not need Changelog entries= . I feel like this patch is pretty minor, so I'm not sure if it warrants a = Changelog entry. Let me know what you think. Thanks, Brian > ---------------------------------------- > From: Andrea Corallo > Sent: Mon Oct 12 09:05:31 CEST 2020 > To: Brian Leung via "Bug reports for GNU Emacs the Swiss army knife of te= xt editors" > Cc: <43892@debbugs.gnu.org>, Brian Leung > Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings >=20 >=20 > Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text > editors" writes: >=20 > > Actually, I'm not sure my most recent patch is necessary. Please review= this instead, which is the first one again. > > >=20 > Hi Brian, >=20 > could you double check the patch applies and re-send it with a ChangeLog > entry (see ** Commit messages in the CONTRIBUTE file)? >=20 > Thanks >=20 > Andrea --=C2=A0 Sent with https://mailfence.com Secure and private email ------=_Part_302631_47977201.1602524237268 Content-Type: text/x-diff; charset=us-ascii; name=0001-Fix-some-compilation-warnings.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0001-Fix-some-compilation-warnings.patch Content-Disposition: attachment; filename=0001-Fix-some-compilation-warnings.patch >From 004abde9b6a20677d6eafefc50834b257a44edf2 Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 9 Oct 2020 14:35:26 -0700 Subject: [PATCH] ; Fix some compilation warnings lisp/emacs-lisp/advice.el: Declare comp-subr-trampoline-install function. lisp/emacs-lisp/find-func.el: Declare comp-eln-to-el-h variable. lisp/emacs-lisp/nadvice.el: Declare comp-subr-trampoline-install function. lisp/files.el: Declare comp-eln-to-el-h variable. lisp/help.el: Declare subr-native-lambda-list function. --- lisp/emacs-lisp/advice.el | 2 ++ lisp/emacs-lisp/find-func.el | 2 ++ lisp/emacs-lisp/nadvice.el | 2 ++ lisp/files.el | 2 ++ lisp/help.el | 2 ++ 5 files changed, 10 insertions(+) diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index fb67de3a02..509e255191 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -2052,6 +2052,8 @@ ad-remove-advice function class name))) (error "ad-remove-advice: `%s' is not advised" function))) +(declare-function comp-subr-trampoline-install "comp") + ;;;###autoload (defun ad-add-advice (function advice class position) "Add a piece of ADVICE to FUNCTION's list of advices in CLASS. diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index 9e4d8cf1aa..4417082971 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -178,6 +178,8 @@ find-library--load-name (setq name rel)))) (unless (equal name library) name))) +(defvar comp-eln-to-el-h) + (defun find-library-name (library) "Return the absolute file name of the Emacs Lisp source of LIBRARY. LIBRARY should be a string (the name of the library)." diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el index 8b60c08440..e68c135608 100644 --- a/lisp/emacs-lisp/nadvice.el +++ b/lisp/emacs-lisp/nadvice.el @@ -316,6 +316,8 @@ add-function `(advice--add-function ,where (gv-ref ,(advice--normalize-place place)) ,function ,props)) +(declare-function comp-subr-trampoline-install "comp") + ;;;###autoload (defun advice--add-function (where ref function props) (when (and (featurep 'nativecomp) diff --git a/lisp/files.el b/lisp/files.el index 833a188b03..1d330ce87b 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -900,6 +900,8 @@ load-file (read-file-name "Load file: " nil nil 'lambda)))) (load (expand-file-name file) nil nil t)) +(defvar comp-eln-to-el-h) + (defun locate-file (filename path &optional suffixes predicate) "Search for FILENAME through PATH. If found, return the absolute file name of FILENAME; otherwise diff --git a/lisp/help.el b/lisp/help.el index c166b63a56..1a3fd35e44 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1320,6 +1320,8 @@ help-add-fundoc-usage (error "Unrecognized usage format")) (help--make-usage-docstring 'fn arglist))))) +(declare-function subr-native-lambda-list "data.c") + (defun help-function-arglist (def &optional preserve-names) "Return a formal argument list for the function DEF. If PRESERVE-NAMES is non-nil, return a formal arglist that uses -- 2.28.0 ------=_Part_302631_47977201.1602524237268--