From: Carsten Dominik <dominik@science.uva.nl>
Cc: Carsten Dominik <dominik@science.uva.nl>,
emacs-devel@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: Inefficient code in reftex-index.el
Date: Mon, 6 Jun 2005 16:41:06 +0200 [thread overview]
Message-ID: <17060.24706.245710.106599@sam.science.uva.nl> (raw)
In-Reply-To: <85slzv7j87.fsf@lola.goethe.zz>
>>>>> "DK" == David Kastrup <dak@gnu.org> writes:
DK> storm@cua.dk (Kim F. Storm) writes:
>> I noticed the following code in reftex-index.el:
>>
>> (condition-case nil (texmathp) (error nil))))
>> (setq beg (car (match-data))
>> end (nth 1 (match-data)))
>>
>> Using match-data like that seems inefficient.
>>
>> I suggtest using match-beginning/match-end instead.
DK> That is not the same: the above will set beg and end to markers,
DK> whereas match-beginning/match-end happen to be integers.
Yes, indeed markers are needed here. I will change it like Stafan
proposed it. Thanks for picking this up, Kim.
I don't understand your ironic reply to Davids email. Entirely
unnecessary.
- Carsten
--
Carsten Dominik <dominik@science.uva.nl> \ _ /
Sterrenkundig Instituut "Anton Pannekoek" |X| _
Kruislaan 403; NL-1098 SJ Amsterdam /| |\ _ _ _/ \
phone +31 (20) 525-7477; FAX +31 (20) 525-7484 __|o|___/ ~~ \___/ ~~~
prev parent reply other threads:[~2005-06-06 14:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 12:08 Inefficient code in reftex-index.el Kim F. Storm
2005-06-06 12:39 ` David Kastrup
2005-06-06 13:52 ` Stefan Monnier
2005-06-06 14:14 ` Kim F. Storm
2005-06-06 14:15 ` Juanma Barranquero
2005-06-06 14:18 ` Kim F. Storm
2005-06-06 22:24 ` Kim F. Storm
2005-06-06 23:55 ` David Kastrup
2005-06-07 8:46 ` Kim F. Storm
2005-06-07 9:23 ` David Kastrup
2005-06-07 10:38 ` Kim F. Storm
2005-06-07 11:05 ` David Kastrup
2005-06-07 11:28 ` Kim F. Storm
2005-06-07 14:28 ` Richard Stallman
2005-06-07 14:46 ` Kim F. Storm
2005-06-07 18:06 ` Stefan Monnier
2005-06-08 8:44 ` Kim F. Storm
2005-06-08 9:47 ` David Kastrup
2005-06-08 10:00 ` Kim F. Storm
2005-06-08 10:11 ` David Kastrup
2005-06-08 15:59 ` Richard Stallman
2005-06-08 16:25 ` David Kastrup
2005-06-09 14:40 ` Richard Stallman
2005-06-09 15:05 ` David Kastrup
2005-06-10 13:30 ` Richard Stallman
2005-06-10 14:13 ` David Kastrup
2005-06-07 14:28 ` Richard Stallman
2005-06-07 14:35 ` David Kastrup
2005-06-08 15:59 ` Richard Stallman
2005-06-07 14:42 ` Kim F. Storm
2005-06-07 18:11 ` Stefan Monnier
2005-06-08 12:01 ` Richard Stallman
2005-06-08 23:08 ` Kim F. Storm
2005-06-07 12:24 ` Richard Stallman
2005-06-06 14:41 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17060.24706.245710.106599@sam.science.uva.nl \
--to=dominik@science.uva.nl \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.