From: Nick Roberts <nickrob@snap.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: log-edit.el
Date: Thu, 26 May 2005 19:14:45 +1200 [thread overview]
Message-ID: <17045.30566.3446.692950@farnswood.snap.net.nz> (raw)
In-Reply-To: <E1DbBQU-00049c-Dg@fencepost.gnu.org>
Richard Stallman writes:
> (dolist (file files)
> ! ;; Prefix filename with a space to distinguish e.g fns.c xfns.c.
> ! (let* ((entries (log-edit-changelog-entries (concat " " file)))
>
> This change is clearly the wrong way to do it.
> The argument to log-edit-changelog-entries is supposed to be a file name.
> If it doesn't work, you should fix it, not enshrine the error
> by passing an arg that is not a file name.
Yes. But it did motivate Stefan to provide a proper patch.
Nick
next prev parent reply other threads:[~2005-05-26 7:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 11:02 log-edit.el Nick Roberts
2005-05-25 14:33 ` log-edit.el Stefan Monnier
2005-05-25 21:33 ` log-edit.el Nick Roberts
2005-05-26 6:01 ` log-edit.el Richard Stallman
2005-05-26 6:31 ` log-edit.el Nick Roberts
2005-05-27 3:40 ` log-edit.el Richard Stallman
2005-05-26 7:14 ` Nick Roberts [this message]
2005-05-27 3:39 ` log-edit.el Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17045.30566.3446.692950@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.