From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#37656: 27.0.50; Arbitrary code execution with special `mode:' Date: Thu, 17 Oct 2019 08:09:04 +1300 Message-ID: <16f494c4-be3a-09d7-1c56-d58647059c44@orcon.net.nz> References: <838splf7g1.fsf@gnu.org> <83d0ewehxf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18862"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Adam Plaice , 37656@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 21:10:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKogW-0004fi-5q for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 21:10:12 +0200 Original-Received: from localhost ([::1]:47258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKogU-0004Ii-ET for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 15:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59420) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKogN-0004IY-Co for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKogM-0003ip-E3 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKogM-0003ik-As for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKogM-0000Ku-4K for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 15:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37656 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 37656-submit@debbugs.gnu.org id=B37656.15712529501231 (code B ref 37656); Wed, 16 Oct 2019 19:10:02 +0000 Original-Received: (at 37656) by debbugs.gnu.org; 16 Oct 2019 19:09:10 +0000 Original-Received: from localhost ([127.0.0.1]:46566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKofW-0000Jn-Jd for submit@debbugs.gnu.org; Wed, 16 Oct 2019 15:09:10 -0400 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]:34231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKofU-0000JX-Fk for 37656@debbugs.gnu.org; Wed, 16 Oct 2019 15:09:09 -0400 Original-Received: from [116.251.203.173] (port=38687 helo=[192.168.20.103]) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1iKofR-0007vG-Eo; Thu, 17 Oct 2019 08:09:05 +1300 In-Reply-To: <83d0ewehxf.fsf@gnu.org> Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169483 Archived-At: > > -*- mode: emacs-lisp; mode: flymake -*- > > This relies on the "deprecated" feature of allowing `mode: ' > > to be repeated more than once, to also specify minor modes. > > Just having: -*- mode: flymake -*- [...] would not trigger > > the security bug. On 17/10/19 6:09 AM, Eli Zaretskii wrote: > I don't think that removing the feature will solve the more > general problem in this bug report. In particular it seems there is no point in removing the deprecated method of calling a minor mode using local variables because, after testing, the *approved* method of calling a minor mode via local variables causes the same behaviour. i.e.: -*- mode: emacs-lisp; eval:(flymake-mode 1); -*- So the deprecated approach isn't actually a factor here. -Phil