all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Adam Plaice <plaiceadam@gmail.com>,
	37656@debbugs.gnu.org, stefan@marxist.se
Subject: bug#37656: 27.0.50; Arbitrary code execution with special `mode:'
Date: Thu, 17 Oct 2019 08:09:04 +1300	[thread overview]
Message-ID: <16f494c4-be3a-09d7-1c56-d58647059c44@orcon.net.nz> (raw)
In-Reply-To: <83d0ewehxf.fsf@gnu.org>

> > -*- mode: emacs-lisp; mode: flymake -*-
> > This relies on the "deprecated" feature of allowing `mode: '
> > to be repeated more than once, to also specify minor modes.
> > Just having: -*- mode: flymake -*- [...] would not trigger
> > the security bug.


On 17/10/19 6:09 AM, Eli Zaretskii wrote:
> I don't think that removing the feature will solve the more
> general problem in this bug report.


In particular it seems there is no point in removing the deprecated
method of calling a minor mode using local variables because, after
testing, the *approved* method of calling a minor mode via local
variables causes the same behaviour.  i.e.:

-*- mode: emacs-lisp; eval:(flymake-mode 1); -*-


So the deprecated approach isn't actually a factor here.


-Phil






  reply	other threads:[~2019-10-16 19:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 21:05 bug#37656: 27.0.50; Arbitrary code execution with special `mode:' adam plaice
2019-10-15 22:23 ` Clément Pit-Claudel
2019-10-15 22:27 ` Stefan Kangas
2019-10-15 22:27 ` Stefan Kangas
2019-10-15 22:55   ` Stefan Kangas
2019-10-15 23:17     ` Stefan Kangas
2019-10-15 23:17     ` Stefan Kangas
2019-10-16  7:58       ` Eli Zaretskii
2019-10-16 11:51         ` Adam Plaice
2019-10-16 17:09           ` Eli Zaretskii
2019-10-16 19:09             ` Phil Sainty [this message]
2019-10-16 19:34               ` Eli Zaretskii
2019-10-16 21:02               ` Adam Plaice
2019-10-16  0:35     ` Adam Plaice
2019-10-16  7:57       ` Eli Zaretskii
2019-10-16  0:55     ` Phil Sainty
2019-10-16  0:55     ` Phil Sainty
2019-10-16  7:59     ` Eli Zaretskii
2019-10-16  6:43 ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2019-10-08  8:48 bug#37656: 27.0.50; Opening file with specially crafted local variables can cause arbitrary code execution Inbox x adam plaice
2019-10-15 21:05 ` bug#37656: 27.0.50; Arbitrary code execution with special `mode:' adam plaice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16f494c4-be3a-09d7-1c56-d58647059c44@orcon.net.nz \
    --to=psainty@orcon.net.nz \
    --cc=37656@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=plaiceadam@gmail.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.