From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sat, 10 Dec 2022 21:53:28 +0200 Message-ID: <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="829"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 20:54:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p45vO-000AZm-70 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 20:54:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p45v9-0002SZ-OF; Sat, 10 Dec 2022 14:54:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p45v8-0002SQ-Ds for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p45v7-00061V-U4 for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p45v7-0005L5-QI for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070201820508 (code B ref 59935); Sat, 10 Dec 2022 19:54:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:53:38 +0000 Original-Received: from localhost ([127.0.0.1]:44744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45uk-0005Ki-05 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:53:38 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:38735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45uh-0005Kc-Vy for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:53:37 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id r7-20020a1c4407000000b003d1e906ca23so970853wma.3 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 11:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=35UEx3HW7QBVRRwWhCSKwUm0vsaYq6OY9HMqQxCH9no=; b=GePGKjNYvTq3eQ5m7E7THg3CmJAXdvLBV+W9+4U/wNrR7IbiK1vgGUlFoZlbalfoJy rW77Kd2wsw0hhFKk5ZRQYOupHrcoANNuMZ/eIvqL9zye7T3VEIy/amTf5e6u1hITv/4M S3a2qGNeK0rBXXfEWvtZabcwo0EPngHlyKsnD0R0jcb6a99WzSQYTJ0WsxY/GWB32OTi h+PA2hFXxrkceyl16B07I35gzz+wn6TYd+uwZVPLHpt7AAwf4aXrJX9Di7ViXt4XhUnl vQsAj58MsKNd6g7MtF9jMPqaTN5/stgeuf4U45PenSWqbyt9gTY16jqUzq7wDdFMBIP5 HVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=35UEx3HW7QBVRRwWhCSKwUm0vsaYq6OY9HMqQxCH9no=; b=Mnn7ehhiqMXpSEsxk6QtMsyRBR9jwkMCb9e0jlWhr20CKCbJFKLCfp454ecSluBZO+ 3uToP/uwQQzJ33gR9yqt9fqOzwS/eMEpGTEd4tKBFNJcJ/h1xy+/qUoZGIPQTf9hsnRS IUmPLwTILulGCnjTBP6Vs2PcJgFgOHj1Y3Ieaod61XiE/H7khiH4R0xGm6Fnan/cZtx1 SwXNjHJo2jxpZ++suWQq4TVOC9SCDyvTPIOm+ueuQZlzc+tOJwSUob86qbmdSUyClw/X NzssTR68kbEzWJ4ZX2/sHWAt37twL4/3aVgNICoB8FxwkNNaYO1JGGULxXA4WovQyGCC iSzQ== X-Gm-Message-State: ANoB5pkLBvonFvnROiw0ahv3Hi1eB5GNy2d7OgFsm/EFq2SqqXgjHbGr wU0tBE+wSY9gyf52j4Kyg/I= X-Google-Smtp-Source: AA0mqf6Nz1F7LIbi1rI+AVe5R9HebKFPfBGyIlsvMXHUw8Kg3gHjCQqPft9xoP4FzDgLPAhjHnaQ5Q== X-Received: by 2002:a05:600c:4f85:b0:3cf:93de:14e8 with SMTP id n5-20020a05600c4f8500b003cf93de14e8mr8302639wmq.39.1670702010450; Sat, 10 Dec 2022 11:53:30 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r5-20020a05600c35c500b003a2f2bb72d5sm4787572wmq.45.2022.12.10.11.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 11:53:30 -0800 (PST) Content-Language: en-US In-Reply-To: <834ju3vyeb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250554 Archived-At: On 10/12/2022 21:42, Eli Zaretskii wrote: >> Date: Sat, 10 Dec 2022 21:19:30 +0200 >> Cc:59935@debbugs.gnu.org,juri@linkov.net >> From: Dmitry Gutov >> >> On 10/12/2022 16:33, Eli Zaretskii wrote: >>> OK, but I didn't suggest making any changes to revert-buffer-function >>> set up by "C-x p C-b". You can still use process-buffers there, and >>> it shouldn't slow down "C-x p C-b" itself, since the call to >>> process-buffers that is part of revert-buffer-function is not supposed >>> to be evaluated when you set revert-buffer-function. Right? Or what >>> else am I missing? >> Then only the 'g' binding will remain slow. An improvement, of course. > Why slow? it calls project-buffers only once. You're looking at the "legacy" code path. Where emacs-version is < 29. In the "new" one revert-buffer-function uses the filter-predicate argument we pass to list-buffers-noselect. Which is (lambda (buf) (memq buf (project-buffers pr)))