From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Charles A. Roelli" Newsgroups: gmane.emacs.bugs Subject: bug#26905: 25.2: MacOS: tooltips show in wrong display Date: Sat, 13 May 2017 16:04:32 +0200 Message-ID: <16a6fc81-06de-8c4a-8159-2f07f50f5585@aurox.ch> References: <83o9ux84h4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1494684337 12774 195.159.176.226 (13 May 2017 14:05:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 13 May 2017 14:05:37 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 Cc: 26905@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 13 16:05:31 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Xfl-00038R-H3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 May 2017 16:05:29 +0200 Original-Received: from localhost ([::1]:57749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9Xfr-0003sw-2L for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 May 2017 10:05:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9XfO-0003ei-G8 for bug-gnu-emacs@gnu.org; Sat, 13 May 2017 10:05:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9XfL-000839-Cp for bug-gnu-emacs@gnu.org; Sat, 13 May 2017 10:05:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9XfL-00082I-9f for bug-gnu-emacs@gnu.org; Sat, 13 May 2017 10:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9XfK-0007cK-HN for bug-gnu-emacs@gnu.org; Sat, 13 May 2017 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Charles A. Roelli" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2017 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26905-submit@debbugs.gnu.org id=B26905.149468429429263 (code B ref 26905); Sat, 13 May 2017 14:05:02 +0000 Original-Received: (at 26905) by debbugs.gnu.org; 13 May 2017 14:04:54 +0000 Original-Received: from localhost ([127.0.0.1]:43054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Xf8-0007br-Ho for submit@debbugs.gnu.org; Sat, 13 May 2017 10:04:54 -0400 Original-Received: from sinyavsky.aurox.ch ([37.35.109.145]:46481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9Xf6-0007ba-1R for 26905@debbugs.gnu.org; Sat, 13 May 2017 10:04:49 -0400 Original-Received: from sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) by sinyavsky.aurox.ch (Postfix) with ESMTP id 7AB6622428 for <26905@debbugs.gnu.org>; Sat, 13 May 2017 14:00:25 +0000 (UTC) Authentication-Results: sinyavsky.aurox.ch (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=aurox.ch DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aurox.ch; h= content-transfer-encoding:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:to:subject:subject; s=dkim; t=1494684021; x= 1495548022; bh=qur9mJ7kz87AFkl4xWHTvrOqPeaR+0+aM/NrA3dphWY=; b=D /OQHw0jnl3oyIFBwKh+11BoRWpkv0J/Ee8vRur5OwPV7IhnVhrpPXdqSxWCRkYPp h2pmuAFblh2JIRokBBos14E+2KiYUwT1QA8Ex5AhqjIuAhk/nrHH0JgAc50BmOfi QEEl3HqC+RryY9UpbfOy5CBvUuLT/Xq6YwRAnAKWLs= X-Virus-Scanned: Debian amavisd-new at test.virtualizor.com Original-Received: from sinyavsky.aurox.ch ([127.0.0.1]) by sinyavsky.aurox.ch (sinyavsky.aurox.ch [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hmYw01rU-GyU for <26905@debbugs.gnu.org>; Sat, 13 May 2017 14:00:21 +0000 (UTC) Original-Received: from [192.168.1.106] (179.133.105.92.dynamic.wline.res.cust.swisscom.ch [92.105.133.179]) by sinyavsky.aurox.ch (Postfix) with ESMTPSA id B294F22422; Sat, 13 May 2017 14:00:17 +0000 (UTC) In-Reply-To: <83o9ux84h4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132469 Archived-At: FWIW, I found this change to the Windows port of Emacs (not sure if it was ever committed): https://lists.gnu.org/archive/html/bug-gnu-emacs/2007-07/msg00153.html And a more recent change as a result of #22549: commit c77ffc8019bceb850a794c13f2e3ad991cc7e412, with changes to xfns.c. c77ffc8..: Oscar Fuentes 2016-02-06 Use monitor's resolution for positioning tooltips commit c77ffc8019bceb850a794c13f2e3ad991cc7e412 Author: Oscar Fuentes Date: Sat Feb 6 22:12:53 2016 +0100 Use monitor's resolution for positioning tooltips * src/xfns.c (compute_tip_xy): Use the resolution of the monitor where the mouse pointer is to avoid placing the tooltip over the border of the monitor on multi-head displays. Fixes bug#22549. Seems like the Windows and X versions nowadays have a check that looks like this: else if (*root_x + XINT (dx) <= min_x) *root_x = 0; /* Can happen for negative dx */ i.e. compare *root_x + XINT (dx) against the variable "min_x", rather than comparing against zero, as is done in the NS port. Since frames can be in the negative coordinate space, it makes sense to allow a tooltip to have a x-coordinate less than 0 -- so the NS port's code should probably be changed. I'm also not sure why, in the above code from the Windows and X versions, *root_x is constrained to zero if *root_x + dx goes below min_x. Wouldn't it make more sense to constrain to min_x, which could be negative? On 13/05/2017 11:56, Eli Zaretskii wrote: >> From: "Charles A. Roelli" >> Date: Sat, 13 May 2017 11:02:04 +0200 >> >> If I remove the marked lines in compute_tip_xy: >> >> if (INTEGERP (left) || INTEGERP (right)) >> *root_x = pt.x; >> => else if (pt.x + XINT (dx) <= 0) >> => *root_x = 0; /* Can happen for negative dx */ >> else if (pt.x + XINT (dx) + width >> <= x_display_pixel_width (FRAME_DISPLAY_INFO (f))) >> /* It fits to the right of the pointer. */ >> *root_x = pt.x + XINT (dx); >> else if (width + XINT (dx) <= pt.x) >> /* It fits to the left of the pointer. */ >> *root_x = pt.x - width - XINT (dx); >> else >> /* Put it left justified on the screen -- it ought to fit that way. */ >> *root_x = 0; >> >> Then the problem is gone. > Those lines were added to fix some problems (whose particulars I > cannot find at the moment), so we shouldn't remove them without > understanding what is going on.