From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix some failing tests in BSD systems Date: Wed, 6 Jan 2021 19:17:44 +0200 Message-ID: <16a47655-7d4c-2111-cae3-7168ec953fb1@yandex.ru> References: <83a6tpdiuf.fsf@gnu.org> <5e881738-2df3-d5e3-9a46-bc4304ff4092@yandex.ru> <835z4dcrah.fsf@gnu.org> <5d574d90-34b1-0fb1-8b3a-83e7709eadfc@yandex.ru> <83pn2kbsy5.fsf@gnu.org> <6e35988f-fdf0-5384-1aaa-e8e21effead9@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Eli Zaretskii , emacs-devel@gnu.org To: =?UTF-8?Q?Daniel_Mart=c3=adn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 06 18:19:07 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxCSg-0005CH-Dr for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 18:19:06 +0100 Original-Received: from localhost ([::1]:41368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxCSf-0005Dt-FU for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Jan 2021 12:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxCRT-0004ka-QH for emacs-devel@gnu.org; Wed, 06 Jan 2021 12:17:51 -0500 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:45112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxCRS-00007b-41; Wed, 06 Jan 2021 12:17:51 -0500 Original-Received: by mail-wr1-x433.google.com with SMTP id d26so3071684wrb.12; Wed, 06 Jan 2021 09:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+3FCykI3a9mNjGj/iBQe7xr0VeZ18UjjUwCUGBssxqo=; b=TsRNbPm0N3UDhVR7GsP4uE8ntiT+eutDcVjmrkK27RAssIDvf0GUpRdSxRH3kNLGQA hYRhgyx3tIqoRD4FUZeIv4TE85hqSScxFOZzIyLCvvIlQ6SR2EPUnPEwiJnFaU5kIDfU b2SSfigavZcnA/dBtHnUj+LXGcwwfgzqb7GNEkgG5jCZJsyTYSOOQ6st2vSnhihkwOHc m6EKQbjiGAnY70BZl+7DY31hiApRn7VzrOiUfMxLXVfi1BUzK2arbqpp3HOvcrns9d7K IjRC8Luxsv1IX4zx7/OXHsOlvdvK62IPwBiZya8XrbZGsSTMmdqTbFquVnTaemxu3o/+ b67A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+3FCykI3a9mNjGj/iBQe7xr0VeZ18UjjUwCUGBssxqo=; b=R5kMeddkWR0ha53hCDvyKpN+VZOShhnR7/0Ex6lJJX0lJIbuhNjRhVcW35qxmzUKkj S+DrB6rYlAwKFJTRhCPPl7y9QKDt1+/ga4lVvvm4nQxmNTKWdS8qAjjWre02mzukDspO ObrkigcMg5liHyWvzQ0lQI5JrMyNjymJXbKnjwyjijXaS+TtRKoyeiSfoOIUOx18rRrM tIk1YETzDf09xrmbSISKhP71I74mFw4CLNipFsZzmHx8mrw6TzgpWoelCnLTrXk29mBk KsKHtz0vUv6YKosY0qeuv+DMiwqizIgK80CeilGS855lzPF51aXhuWfdkkPrKZ5zdNzo QjRw== X-Gm-Message-State: AOAM531meEBi2hn3CJlr1ZCxRYfR7Ow41LR0LkinOplylZZ7NBqCr5Ey MFS4ss9iOgkoRMnHAWa8Kwga9n6qPdFsEQ== X-Google-Smtp-Source: ABdhPJzuKxkm9dN/uObNypsGEm+AFPM/43C89Ie9srmpWDxn9rDV5D448haJydMFPrkNazz4t6ewCw== X-Received: by 2002:adf:fbd2:: with SMTP id d18mr5309826wrs.222.1609953467994; Wed, 06 Jan 2021 09:17:47 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e17sm3867095wrw.84.2021.01.06.09.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 09:17:47 -0800 (PST) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=raaahh@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262622 Archived-At: On 06.01.2021 11:41, Daniel Martín wrote: >> So I guess I should ask: was the particular behavior annoying by >> itself, or is it only a problem because of the failing test? >> >> I also wonder whether all macOS users see this, or whether it's maybe >> fixed in some latest version of BSD find. Because it's apparently >> (arguably) a bug: https://unix.stackexchange.com/a/320440/166215 > > I think the safest and simplest route is to just "fix" the tests so they > pass in all systems. We shouldn't risk introducing regressions just to > work around what POSIX says could be a 'find' bug in some BSD systems > (and maybe only Apple systems, I don't have any other BSD system to test > with). Thanks, that makes sense. We do try to work around problems in widely installed software, but so far it seems Apple-only. I've tried a few major versions of FreeBSD in a VM, going back to 11.4, and none have exhibited the problem. Guess we'll do the fix for the symlinks problem instead (the easy way), and then wait and see whether more reports come complaining about the double-slash issue. > It only causes a slight cosmetic problem, which should be fixed whenever > they fix the bug, without needing any code change from our side. AFAIK Apple tries very hard to avoid updating to the latest versions of Unixy tools. Luckily, there are now several projects that let users install fresh GNU versions of said tools (and other command-line programs).