From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Gildea Newsgroups: gmane.emacs.devel Subject: Re: master 4cc4344: ; Clarify and simplify time-stamp comments Date: Thu, 14 Oct 2021 20:41:03 -0700 Message-ID: <1694192.1634269263@pental> References: <87lf2vwuxk.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36996"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 05:42:04 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbE6e-0009R8-Io for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 05:42:04 +0200 Original-Received: from localhost ([::1]:46162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbE6c-0001dR-T5 for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 23:42:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbE5r-0000vm-2h for emacs-devel@gnu.org; Thu, 14 Oct 2021 23:41:15 -0400 Original-Received: from tigger.sg.gildea.net ([99.65.78.170]:57794 helo=pental.sg.gildea.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbE5p-00022d-54 for emacs-devel@gnu.org; Thu, 14 Oct 2021 23:41:14 -0400 Original-Received: from pental (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by pental.sg.gildea.net (Postfix) with ESMTPS id 88AE025566C; Thu, 14 Oct 2021 20:41:03 -0700 (PDT) In-Reply-To: Message from larsi@gnus.org of 14 Oct 2021 16:19:19 +0200 <87lf2vwuxk.fsf@gnus.org> X-Mailer: MH-E 8.6+git; nmh 1.7.1; Emacs 29.0.50 Content-ID: <1694191.1634269263.1@pental> Received-SPF: pass client-ip=99.65.78.170; envelope-from=stepheng+emacs@gildea.com; helo=pental.sg.gildea.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277084 Archived-At: Lars Ingebrigtsen wrote: > The main idea behind this patch (which no longer applies) is that we > could rewrite `time-stamp-string-preprocess' to just use `format-spec'. > I vaguely remember there being some corner case that `format-spec' > didn't support yet, but you've simplified the time-spec syntax a bit > meanwhile, so perhaps it's possible now. > > Anyway, I'm just including the patch below -- perhaps it can be used for > inspiration, but if not, just disregard it. The spec of time-stamp-format is indeed somewhat complicated, mostly for backward compatibility. (Compatibility is important in time-stamp because files can specify old formats in local variables.) I plan to simplify the format still further, after a suitable transition time. I will keep your patch and use it for inspiration on my next pass through time-stamp-string-preprocess. Thank you for your attention to simplifying time-stamp. < Stephen