From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: kifer@cs.sunysb.edu (Michael Kifer) Newsgroups: gmane.emacs.devel Subject: Re: ediff and coding systems Date: Sun, 28 Oct 2007 17:01:20 -0400 Message-ID: <16925.1193605280@cs.sunysb.edu> References: NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1193605303 9768 80.91.229.12 (28 Oct 2007 21:01:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2007 21:01:43 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 28 22:01:45 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImFGT-0006aw-1K for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 22:01:45 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImFGK-0001uD-3G for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 17:01:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImFGG-0001ty-DG for emacs-devel@gnu.org; Sun, 28 Oct 2007 17:01:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImFGF-0001ti-1g for emacs-devel@gnu.org; Sun, 28 Oct 2007 17:01:32 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImFGE-0001tf-Qq for emacs-devel@gnu.org; Sun, 28 Oct 2007 17:01:30 -0400 Original-Received: from sbcs.cs.sunysb.edu ([130.245.1.15]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImFGB-0000y9-Gr; Sun, 28 Oct 2007 17:01:27 -0400 Original-Received: from localhost (compserv1 [130.245.1.44]) by sbcs.cs.sunysb.edu (8.13.6/8.12.11) with ESMTP id l9SL1Jpk028163; Sun, 28 Oct 2007 17:01:19 -0400 (EDT) Original-Received: from [127.0.0.1]:10025 (kiferserv [127.0.0.1]) by localhost (Postfix) with ESMTP id 1D2E88B771; Sun, 28 Oct 2007 17:01:20 -0400 (EDT) In-Reply-To: Message from Dan Nicolaescu of "Sat, 27 Oct 2007 14:03:15 PDT." <200710272103.l9RL3Gai024901@oogie-boogie.ics.uci.edu> X-Mailer: MH-E 8.0.3+cvs; nmh 1.1; GNU Emacs 23.0.50 X-detected-kernel: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81988 Archived-At: > kifer@cs.sunysb.edu (Michael Kifer) writes: > > > > kifer@cs.sunysb.edu (Michael Kifer) writes: > > > > > > > > kifer@cs.sunysb.edu (Michael Kifer) writes: > > > > > > > > This one is strange > > > > > > > > > viper-cmd.el:5099:1:Warning: the following functions are not known to > > > be defined: quail-input-method, quail-start-translation, > > > event-to-character, character-to-event, viper-iconify, key-press-event-p, event-key, > > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > These should be optimized out by the byte compiler. > > > > No idea. The above are mostly XEmacs functions. > > These warnings show up because the XEmacs functions are conditionally > called with the condition being the viper-xemacs-p defconst. > Defconsts cannot be optimized out at compile time. > > > > > Also viper-xemacs-p is about as long as (featurep 'emacs) and as > > > readable. Why not replace it? Most similar macros have been replaced > > > in CVS. > > > > > > I do not really care, but see no reason why waste time on this one. > > Would you mind if I do it? For viper* and ediff* ? I do not mind, but I am doing some changes now and do not want conflicts to arise. Hold off for a couple of weeks. > Doing this will allow the byte compiler to get rid code at compile > time, this saves a few kilobytes of disk space. I claim that a few Kbs are not worth of anybody's time these days.