[PATCH org-contrib 0/1] Fix org-eldoc functionality

[PATCH org-contrib 0/1] Fix org-eldoc functionality

[~dalanicolai]

Eldoc functionality only works after a restricted set of commands (see
the variable 'eldoc-message-commands'). Because `org-self-insert-
command', by default, is not in that list, eldoc functionality works
poorly in org-mode (it does not work when typing, only when navigating).
This patch fixes it for when using org-eldoc.el.

Daniel Nicolai (1):
  Fix org-eldoc: add 'org-self-insert-command' to
    'eldoc-message-commands'

 lisp/org-eldoc.el | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.38.4

[PATCH org-contrib 1/1] Fix org-eldoc: add 'org-self-insert-command' to 'eldoc-message-commands'

[~dalanicolai]

From: Daniel Nicolai <dalanicolai@gmail.com>

---
 lisp/org-eldoc.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/org-eldoc.el b/lisp/org-eldoc.el
index 5b4f66d..7137c46 100644
--- a/lisp/org-eldoc.el
+++ b/lisp/org-eldoc.el
@@ -54,6 +54,8 @@
   :group 'org-eldoc
   :type 'string)
 
+(eldoc-add-command 'org-self-insert-command)
+
 (defun org-eldoc-get-breadcrumb ()
   "Return breadcrumb if on a headline or nil."
   (let ((case-fold-search t) cur)
-- 
2.38.4

Re: [PATCH org-contrib 0/1] Fix org-eldoc functionality

[Ihor Radchenko]

~dalanicolai <dalanicolai@git.sr.ht> writes:

> Eldoc functionality only works after a restricted set of commands (see
> the variable 'eldoc-message-commands'). Because `org-self-insert-
> command', by default, is not in that list, eldoc functionality works
> poorly in org-mode (it does not work when typing, only when navigating).
> This patch fixes it for when using org-eldoc.el.

Applied, onto master.
https://git.sr.ht/~bzg/org-contrib/commit/aed67d095de23bc45446777f7b8fb30b8e5c0c51

Do note that we only provide minimal maintenance for org-contrib.
Packages from org-contrib are looking for new proper maintainers.
See https://orgmode.org/worg/org-orphanage.html

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [PATCH org-contrib 0/1] Fix org-eldoc functionality

[dalanicolai]

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

Thanks, for the quick merge. And noted... :)


On Thu, 25 May 2023 at 13:03, Ihor Radchenko <yantar92@posteo.net> wrote:

> ~dalanicolai <dalanicolai@git.sr.ht> writes:
>
> > Eldoc functionality only works after a restricted set of commands (see
> > the variable 'eldoc-message-commands'). Because `org-self-insert-
> > command', by default, is not in that list, eldoc functionality works
> > poorly in org-mode (it does not work when typing, only when navigating).
> > This patch fixes it for when using org-eldoc.el.
>
> Applied, onto master.
>
> https://git.sr.ht/~bzg/org-contrib/commit/aed67d095de23bc45446777f7b8fb30b8e5c0c51
>
> Do note that we only provide minimal maintenance for org-contrib.
> Packages from org-contrib are looking for new proper maintainers.
> See https://orgmode.org/worg/org-orphanage.html
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 1974 bytes --]