From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file Date: Sun, 13 Sep 2020 19:06:39 +0200 (CEST) Message-ID: <1670898213.459425.1600016799389@ichabod.co-bxl> References: <197409406.192953.1598809591346@ichabod.co-bxl> <9aa79095-18d6-d0bd-18ad-aa5d90f0bb1d@yandex.ru> <1898378843.430816.1599957743795@ichabod.co-bxl> <83bli9db3t.fsf@gnu.org> Reply-To: Brian Leung , Brian Leung Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14309"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 43117@debbugs.gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 19:07:38 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHVTW-0003bg-9P for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 19:07:38 +0200 Original-Received: from localhost ([::1]:41924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHVTV-0000Lx-CA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 13:07:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHVSw-0008Vy-BD for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHVSw-0000Nq-2G for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHVSv-00042h-UI for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 13:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43117-submit@debbugs.gnu.org id=B43117.160001681115513 (code B ref 43117); Sun, 13 Sep 2020 17:07:01 +0000 Original-Received: (at 43117) by debbugs.gnu.org; 13 Sep 2020 17:06:51 +0000 Original-Received: from localhost ([127.0.0.1]:51565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVSl-000428-BL for submit@debbugs.gnu.org; Sun, 13 Sep 2020 13:06:51 -0400 Original-Received: from wilbur.contactoffice.com ([212.3.242.68]:53698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHVSi-00041u-Am for 43117@debbugs.gnu.org; Sun, 13 Sep 2020 13:06:49 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by wilbur.contactoffice.com (Postfix) with ESMTP id C11186FD; Sun, 13 Sep 2020 19:06:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1600016802; bh=2SjvuamwNG8riWqJEYn+6zPsDDsyBI4EvG6kCtpQLLM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From; b=uhUV7wfM3EVyt231V8wm0tzAcf9ye9Mii/zc92q2tN2KQDU8hjOd6uGc7+F4U6mtW 3WZrYrpB9rr1OFqkH9nzdGDk9UqIf3P8wG35MX5XC3EOVLkb4/Yj4sGZPme/e9+yt/ EMSXrUiOHoVJY6dUB/F/IYumLcyXtipHBdhnq5Yh1D8LUwkRh4xqSisH9LcEETl+vp CKNQVSCIQC5VHsdFJKEqzcH+x4O0KdJrIX8Q1nuJj3di6DGqF3K/DPIzVhwyLK0pf7 QKEkCDC7+aV4FW6PUK/0mYv3UL7sTk+/bigvcJGgQVw5/g+RUiWgARh+RCaMLD9w9n Cr8CIiXHh8vrA== In-Reply-To: <83bli9db3t.fsf@gnu.org> X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187987 Archived-At: > I'm not sure I understand the rationale: why would we want to replace > all 'if's with 'when's? I expected that people would find it easier to read 'when'/'unless' than si= ngle-clause 'if' statements. The 'when'/'unless', along with the indentatio= n of the corresponding 'then' clause, immediately signal that there is only= one possible non-nil form returned. With single-clause 'if' statements, yo= u would have to continue reading past the 'then' clause to spot what the 'w= hen'/'unless' and its differing indentation immediately tell you. > ---------------------------------------- > From: Eli Zaretskii > Sent: Sun Sep 13 16:07:02 CEST 2020 > To: Brian Leung , Brian Leung > Cc: , , <43117@debbugs.gnu.org> > Subject: Re: bug#43117: [PATCH] Add .git-blame-ignore-revs file >=20 >=20 > > Cc: 43117@debbugs.gnu.org > > Date: Sun, 13 Sep 2020 02:42:23 +0200 (CEST) > > From: Brian Leung via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > >=20 > > OK, please see attached. Right now there are no extraneous whitespace c= hanges, and the only changes I've made change if -> when in the eshell file= s. > > [...] > > Subject: [PATCH 1/2] eshell: Replace single-clause if statements with w= hens >=20 > I'm not sure I understand the rationale: why would we want to replace > all 'if's with 'when's? Was that discussed, here or elsewhere? if so, > could someone point me to that discussion? >=20 > Thanks. --=C2=A0 Sent with https://mailfence.com Secure and private email