From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, 43117@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#43117: [PATCH] Add .git-blame-ignore-revs file
Date: Sun, 13 Sep 2020 19:06:39 +0200 (CEST) [thread overview]
Message-ID: <1670898213.459425.1600016799389@ichabod.co-bxl> (raw)
In-Reply-To: <83bli9db3t.fsf@gnu.org>
> I'm not sure I understand the rationale: why would we want to replace
> all 'if's with 'when's?
I expected that people would find it easier to read 'when'/'unless' than single-clause 'if' statements. The 'when'/'unless', along with the indentation of the corresponding 'then' clause, immediately signal that there is only one possible non-nil form returned. With single-clause 'if' statements, you would have to continue reading past the 'then' clause to spot what the 'when'/'unless' and its differing indentation immediately tell you.
> ----------------------------------------
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Sun Sep 13 16:07:02 CEST 2020
> To: Brian Leung <leungbk@mailfence.com>, Brian Leung <leungbk@mailfence.com>
> Cc: <dgutov@yandex.ru>, <rpluim@gmail.com>, <43117@debbugs.gnu.org>
> Subject: Re: bug#43117: [PATCH] Add .git-blame-ignore-revs file
>
>
> > Cc: 43117@debbugs.gnu.org
> > Date: Sun, 13 Sep 2020 02:42:23 +0200 (CEST)
> > From: Brian Leung via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > OK, please see attached. Right now there are no extraneous whitespace changes, and the only changes I've made change if -> when in the eshell files.
> > [...]
> > Subject: [PATCH 1/2] eshell: Replace single-clause if statements with whens
>
> I'm not sure I understand the rationale: why would we want to replace
> all 'if's with 'when's? Was that discussed, here or elsewhere? if so,
> could someone point me to that discussion?
>
> Thanks.
--
Sent with https://mailfence.com
Secure and private email
next prev parent reply other threads:[~2020-09-13 17:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 17:46 bug#43117: [PATCH] Add .git-blame-ignore-revs file Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-31 10:16 ` Robert Pluim
2020-08-31 20:11 ` Dmitry Gutov
2020-08-31 20:34 ` Robert Pluim
2020-08-31 20:45 ` Dmitry Gutov
2020-08-31 20:57 ` Robert Pluim
2020-08-31 21:03 ` Dmitry Gutov
2020-09-13 0:42 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-09-13 14:07 ` Eli Zaretskii
2020-09-13 17:06 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-09-13 17:34 ` Eli Zaretskii
2020-09-13 17:57 ` Lars Ingebrigtsen
2020-09-13 18:49 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-18 17:03 ` Stefan Kangas
2020-10-18 17:18 ` Eli Zaretskii
2020-10-18 17:54 ` Stefan Kangas
2020-10-18 17:59 ` Eli Zaretskii
2020-10-18 18:25 ` Stefan Kangas
2020-10-18 18:41 ` Eli Zaretskii
2020-10-19 16:06 ` Stefan Kangas
2020-10-19 16:40 ` Eli Zaretskii
2020-10-20 10:38 ` Lars Ingebrigtsen
2020-10-20 12:05 ` Stefan Kangas
2021-03-12 1:07 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1670898213.459425.1600016799389@ichabod.co-bxl \
--to=bug-gnu-emacs@gnu.org \
--cc=43117@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=leungbk@mailfence.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.