From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reto Zimmermann Newsgroups: gmane.emacs.bugs Subject: bug#62508: 28.2; vhdl-mode ModelSim compile warnings aren't highlighted Date: Mon, 3 Apr 2023 12:16:38 +0200 Message-ID: <165bfef9-c6de-42f0-1bb9-ec093cb954e0@gnu.org> References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------T5tC9znTAwm7GLZoNqlaisbW" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16972"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Cc: "friedrich.beckmann@gmx.de" , Eli Zaretskii , "62508@debbugs.gnu.org" <62508@debbugs.gnu.org> To: Cyril Arnould , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 03 12:17:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjHFV-0004Ab-DZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Apr 2023 12:17:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjHFH-0006bf-TP; Mon, 03 Apr 2023 06:17:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjHFG-0006bW-Ua for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2023 06:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjHFG-0002Jz-MI for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2023 06:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pjHFG-0000jv-Ib for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2023 06:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reto Zimmermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Apr 2023 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62508 X-GNU-PR-Package: emacs Original-Received: via spool by 62508-submit@debbugs.gnu.org id=B62508.16805170112822 (code B ref 62508); Mon, 03 Apr 2023 10:17:02 +0000 Original-Received: (at 62508) by debbugs.gnu.org; 3 Apr 2023 10:16:51 +0000 Original-Received: from localhost ([127.0.0.1]:43384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHF4-0000jQ-DA for submit@debbugs.gnu.org; Mon, 03 Apr 2023 06:16:50 -0400 Original-Received: from asave01.hostfactory.ch ([185.117.170.1]:41020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHF0-0000j8-LX for 62508@debbugs.gnu.org; Mon, 03 Apr 2023 06:16:49 -0400 Original-Received: from server09.hostfactory.ch ([185.117.170.110]) by asave01.hostfactory.ch with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjHEs-00BY6b-Sa; Mon, 03 Apr 2023 12:16:41 +0200 Original-Received: from [192.168.0.99] (77-56-245-67.dclient.hispeed.ch [77.56.245.67]) (Authenticated sender: reto@retoweb.net) by server09.hostfactory.ch (Postfix) with ESMTPSA id A298C6020DE6A; Mon, 3 Apr 2023 12:16:37 +0200 (CEST) Content-Language: en-US In-Reply-To: X-PPP-Message-ID: <168051699799.15731.16003046553321331377@server09.hostfactory.ch> X-PPP-Vhost: retoweb.net X-Originating-IP: 185.117.170.110 X-SpamExperts-Domain: outboundprotection.hostfactory.ch X-SpamExperts-Username: 185.117.170.110 Authentication-Results: hostfactory.ch; auth=pass smtp.auth=185.117.170.110@outboundprotection.hostfactory.ch X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.03) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9wS4kumr/8xfRDLK3BY/EnPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5yWwbbxUQS01f/FCDy6901ZPDqq4asyUS/I7uxcPf8M+Aba HwV6xdtSO8Gh1vY3X6XVyF0QxeM3jwV5m7hywo81orjeRycbT70WhFiRqMHhH0iUaBqVSKN3GthC anDkdshSz1/QkI+Moa1kosvnP7RzZhUUYJj2rlcnk4UtRVYMdP0/sYaKo1CrL1ZCjBTPf3RGpcNQ lwkAd6qCmPMQLvLgjjPEWb6iCVLQ9/3YJnY0ujOuGo8BPef7PSR1jW6mjqDWMpPRV9rfPdgGi6aL kUHh9tBOX9IkgN4hslXplx/jfWl8DrSNx0TJ/fdKMx9EisTS0YOWzPrQHWQ+AY0Zlgh4xQ0nfMeJ r16/UsQutzu7g1LDOfadSeFRvtzYfcJkfsV6iMkKKasWAmDjz5Mge69lNAYAyutNu2pqJLVKy0+U 3bIZ/1wK8h2igHqTRrTzTtWqaoUCjzuI+DBeNJmC0lh+vZxMDd2y5YhCK2sm66TSDwbDA2RVI4mU NF3CBprcyhuf4TS7xDZvCPS61ekqpTLhZA+ilPQ7+yozlHD5jgRG3FFU3P4j/yasq2etij2R2V7F DSd8x4mvXr9SxC63O7uD8yexLMqzSz7rpAldK1tbKE5X64tbCJtkxOPnjqyz4rJcRC2f4NQYJSgU b2iUHe8a++DuIQUs/5JJj4C/n4CILrkydOO+IGi7hSiurM7VEjxG9O10WYAqTP5HZhkRvnHUgHw4 drsMT9gZQWox+GIJ+oiTuIFsO8UsQ X-Report-Abuse-To: spam@asave01.hostfactory.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259167 Archived-At: This is a multi-part message in MIME format. --------------T5tC9znTAwm7GLZoNqlaisbW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit The regexp I sent had the "+" in there, it must have gotten lost somewhere in the process.  The single-escaped square brackets always worked fine, but I agree that it should be double-escaped to conform to the standard. So yes, I agree with Mattias' fix. Reto On 03.04.2023 09:21, Cyril Arnould wrote: > True, looking at the new regexp in emacs the escape characters are > highlighted in red, indicating an error. I can verify Mattias' > modification still works for me. > > I can't properly verify the bracketed version of the warning since I > don't get those with my ModelSim, but if I manually type out a warning > with brackets it does get highlighted when using re-builder. With > Reto's modification on the other hand the bracket warning is not > highlighted. > > Gesendet von Outlook für Android > ------------------------------------------------------------------------ > *From:* Mattias Engdegård on behalf of > Mattias Engdegård > *Sent:* Saturday, April 1, 2023 2:01:19 PM > *To:* reto@gnu.org > *Cc:* Cyril Arnould ; Eli Zaretskii > ; friedrich.beckmann@gmx.de ; > 62508@debbugs.gnu.org <62508@debbugs.gnu.org> > *Subject:* bug#62508: 28.2; vhdl-mode ModelSim compile warnings aren't > highlighted > The new regexp, > > "^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( > *\[[0-9]\]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" > ^^^^^^^^^ > > isn't quite right: there are single-escaped square brackets, and the > original regexp permitted multiple digits, not just one, between > square brackets. The part > >   "\[[0-9]\]" > > should probably be > >   "\\[[0-9]+]" > > but the author needs to confirm this. > --------------T5tC9znTAwm7GLZoNqlaisbW Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit The regexp I sent had the "+" in there, it must have gotten lost somewhere in the process.  The single-escaped square brackets always worked fine, but I agree that it should be double-escaped to conform to the standard.

So yes, I agree with Mattias' fix.

Reto


On 03.04.2023 09:21, Cyril Arnould wrote:
True, looking at the new regexp in emacs the escape characters are highlighted in red, indicating an error. I can verify Mattias' modification still works for me.

I can't properly verify the bracketed version of the warning since I don't get those with my ModelSim, but if I manually type out a warning with brackets it does get highlighted when using re-builder. With Reto's modification on the other hand the bracket warning is not highlighted.

From: Mattias Engdegård <mattiasengdegard@gmail.com> on behalf of Mattias Engdegård <mattias.engdegard@gmail.com>
Sent: Saturday, April 1, 2023 2:01:19 PM
To: reto@gnu.org <reto@gnu.org>
Cc: Cyril Arnould <cyril.arnould@outlook.com>; Eli Zaretskii <eliz@gnu.org>; friedrich.beckmann@gmx.de <friedrich.beckmann@gmx.de>; 62508@debbugs.gnu.org <62508@debbugs.gnu.org>
Subject: bug#62508: 28.2; vhdl-mode ModelSim compile warnings aren't highlighted
 
The new regexp,

"^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\[[0-9]\]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):"
                                                                  ^^^^^^^^^

isn't quite right: there are single-escaped square brackets, and the original regexp permitted multiple digits, not just one, between square brackets. The part

  "\[[0-9]\]"

should probably be

  "\\[[0-9]+]"

but the author needs to confirm this.


--------------T5tC9znTAwm7GLZoNqlaisbW--