From: "Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
To: 60546@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#60546: Acknowledgement (29.0.60; typescript-ts-mode and tsx-ts-mode does not highlight variable-declarations in catch-clauses)
Date: Wed, 4 Jan 2023 10:32:33 +0100 [thread overview]
Message-ID: <16239399-0388-a06c-5393-4d83e248d43e@secure.kjonigsen.net> (raw)
In-Reply-To: <0256a96e-46bf-94ce-4db4-a69dd85a0b48@secure.kjonigsen.net>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On 04.01.2023 10:30, Jostein Kjønigsen wrote:
> On 04.01.2023 09:18, GNU bug Tracking System wrote:
>> Thank you for filing a new bug report with debbugs.gnu.org.
>>
>> This is an automatically generated reply to let you know your message
>> has been received.
>>
>> Your message is being forwarded to the package maintainers and other
>> interested parties for their attention; they will reply in due course.
>>
>> Your message has been sent to the package maintainer(s):
>> bug-gnu-emacs@gnu.org
>>
>> If you wish to submit further information on this problem, please
>> send it to 60546@debbugs.gnu.org.
>>
>> Please do not send mail to help-debbugs@gnu.org unless you wish
>> to report a problem with the Bug-tracking system.
>>
> And as usual I have another patch coming up with further
> consistency-improvements. :)
>
> --
> Jostein
And yeah. This one should improve things even further.
Can you tell I'm used to working with pull-requests where I can just
keep on pushing and refining the fixes? :P
--
Jostein
[-- Attachment #2: 0002-Fix-highlighting-of-variable-declarations-in-typescr.patch --]
[-- Type: text/x-patch, Size: 2124 bytes --]
From f1239e02b59df909564bfc0cd9b33704f32a7813 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein@kjonigsen.net>
Date: Wed, 4 Jan 2023 09:13:23 +0100
Subject: [PATCH 2/2] Fix highlighting of variable-declarations in
typescript-ts-mode
lisp/progmodes/typescript-ts-mode.el:
- highlight variable declarations in catch-clauses.
- remove highlighting of variables where not declarations (improve
consistency with other *-ts-modes).
---
lisp/progmodes/typescript-ts-mode.el | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
index e0583f4b05c..011df3e1fbe 100644
--- a/lisp/progmodes/typescript-ts-mode.el
+++ b/lisp/progmodes/typescript-ts-mode.el
@@ -194,7 +194,10 @@ typescript-ts-mode--font-lock-settings
name: (array_pattern
(identifier)
(identifier) @font-lock-function-name-face)
- value: (array (number) (function))))
+ value: (array (number) (function)))
+
+ (catch_clause
+ parameter: (identifier) @font-lock-variable-name-face))
:language language
:override t
@@ -225,13 +228,6 @@ typescript-ts-mode--font-lock-settings
(_ (_ (identifier) @font-lock-variable-name-face))
(_ (_ (_ (identifier) @font-lock-variable-name-face)))])
- (return_statement (identifier) @font-lock-variable-name-face)
-
- (binary_expression left: (identifier) @font-lock-variable-name-face)
- (binary_expression right: (identifier) @font-lock-variable-name-face)
-
- (arguments (identifier) @font-lock-variable-name-face)
-
(parenthesized_expression (identifier) @font-lock-variable-name-face)
(parenthesized_expression (_ (identifier) @font-lock-variable-name-face)))
@@ -245,8 +241,6 @@ typescript-ts-mode--font-lock-settings
(pair key: (property_identifier) @font-lock-variable-name-face)
- (pair value: (identifier) @font-lock-variable-name-face)
-
((shorthand_property_identifier) @font-lock-property-face)
((shorthand_property_identifier_pattern)
--
2.37.2
next prev parent reply other threads:[~2023-01-04 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 8:17 bug#60546: 29.0.60; typescript-ts-mode and tsx-ts-mode does not highlight variable-declarations in catch-clauses Jostein Kjønigsen
[not found] ` <handler.60546.B.16728202687178.ack@debbugs.gnu.org>
2023-01-04 9:30 ` bug#60546: Acknowledgement (29.0.60; typescript-ts-mode and tsx-ts-mode does not highlight variable-declarations in catch-clauses) Jostein Kjønigsen
2023-01-04 9:32 ` Jostein Kjønigsen [this message]
2023-01-04 9:58 ` Jostein Kjønigsen
2023-01-05 21:26 ` Jostein Kjønigsen
2023-01-06 6:09 ` bug#60546: 29.0.60; typescript-ts-mode and tsx-ts-mode does not highlight variable-declarations in catch-clauses Yuan Fu
2023-01-06 7:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-06 7:40 ` Eli Zaretskii
2023-01-08 2:20 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16239399-0388-a06c-5393-4d83e248d43e@secure.kjonigsen.net \
--to=jostein@secure.kjonigsen.net \
--cc=60546@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=jostein@kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.