all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mike Kupfer <kupfer@rawbw.com>
To: Chris Siebenmann <cks.emacsbugs-01@cs.toronto.edu>,
	Bill Wohler <wohler@newt.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 67361@debbugs.gnu.org
Subject: bug#67361: 29.1; MH-E: creating a new folder can sometimes fail with a Lisp error
Date: Fri, 24 Nov 2023 19:56:59 -0800	[thread overview]
Message-ID: <160446.1700884619@alto> (raw)
In-Reply-To: Your message of "Fri, 24 Nov 2023 22:18:16 -0500." <2935352.1700882296@apps0.cs.toronto.edu>

Chris Siebenmann wrote:

> I believe that if the speedbar is active (which I believe is when
> speedbar-buffer is non-nil) and you're in MH-E, the speedbar will be
> showing your MH folder hierarchy instead of anything else. But I'm not
> 100% sure of this.

I've lightly tested the patch below and not seen any problems.  What do
you guys think about it?

mike

diff --git a/lisp/mh-e/mh-funcs.el b/lisp/mh-e/mh-funcs.el
--- a/lisp/mh-e/mh-funcs.el
+++ b/lisp/mh-e/mh-funcs.el
@@ -108,7 +108,7 @@
             (window-config mh-previous-window-config))
         (mh-set-folder-modified-p t)    ; lock folder to kill it
         (mh-exec-cmd-daemon "rmf" 'mh-rmf-daemon folder)
-        (when (boundp 'mh-speed-folder-map)
+        (when (and (boundp 'speedbar-buffer) speedbar-buffer)
           (mh-speed-invalidate-map folder))
         (mh-remove-from-sub-folders-cache folder)
         (mh-set-folder-modified-p nil)  ; so kill-buffer doesn't complain
diff --git a/lisp/mh-e/mh-search.el b/lisp/mh-e/mh-search.el
--- a/lisp/mh-e/mh-search.el
+++ b/lisp/mh-e/mh-search.el
@@ -1569,7 +1569,7 @@
     (save-excursion (mh-exec-cmd-quiet nil "rmf" chosen-name))
     (mh-exec-cmd-quiet nil "folder" "-create" "-fast" chosen-name)
     (mh-remove-from-sub-folders-cache chosen-name)
-    (when (boundp 'mh-speed-folder-map)
+    (when (and (boundp 'speedbar-buffer) speedbar-buffer)
       (mh-speed-add-folder chosen-name))
     chosen-name))
 
diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el
--- a/lisp/mh-e/mh-utils.el
+++ b/lisp/mh-e/mh-utils.el
@@ -795,7 +795,7 @@
              (message "Creating %s" folder-name)
              (mh-exec-cmd-error nil "folder" folder-name)
              (mh-remove-from-sub-folders-cache folder-name)
-             (when (boundp 'mh-speed-folder-map)
+             (when (and (boundp 'speedbar-buffer) speedbar-buffer)
                (mh-speed-add-folder folder-name))
              (message "Creating %s...done" folder-name))
             (new-file-flag





  reply	other threads:[~2023-11-25  3:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22  1:45 bug#67361: 29.1; MH-E: creating a new folder can sometimes fail with a Lisp error Chris Siebenmann
2023-11-22 14:41 ` Eli Zaretskii
2023-11-22 16:30   ` Mike Kupfer
2023-11-25  2:31     ` Mike Kupfer
2023-11-25  3:18       ` Chris Siebenmann
2023-11-25  3:56         ` Mike Kupfer [this message]
2023-12-30 23:33           ` Bill Wohler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-31 16:49             ` Bill Wohler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-16  1:34               ` Bill Wohler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-16 12:24                 ` Eli Zaretskii
2024-01-17 16:47                   ` Bill Wohler via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160446.1700884619@alto \
    --to=kupfer@rawbw.com \
    --cc=67361@debbugs.gnu.org \
    --cc=cks.emacsbugs-01@cs.toronto.edu \
    --cc=eliz@gnu.org \
    --cc=wohler@newt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.