bug#18204: 24.4.50; `ediff-file-compressed-p'

bug#18204: 24.4.50; `ediff-file-compressed-p'

[Drew Adams]

Could be improved from this:

(defun ediff-file-compressed-p (file)
  (condition-case nil
      (require 'jka-compr)
    (error))
  (if (featurep 'jka-compr)
      (string-match (jka-compr-build-file-regexp) file)))

to this:

(defun ediff-file-compressed-p (file)
  (and (require 'jka-compr nil t)
       (string-match-p (jka-compr-build-file-regexp) file)))

Or just remove it altogether - it is used only once.

(Or provide it as a general function, outside `ediff-util'.)

In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

bug#18204: 24.4.50; `ediff-file-compressed-p'

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> Could be improved from this:
>
> (defun ediff-file-compressed-p (file)
>   (condition-case nil
>       (require 'jka-compr)
>     (error))
>   (if (featurep 'jka-compr)
>       (string-match (jka-compr-build-file-regexp) file)))
>
> to this:
>
> (defun ediff-file-compressed-p (file)
>   (and (require 'jka-compr nil t)
>        (string-match-p (jka-compr-build-file-regexp) file)))

Probably written that way for backwards compatibility.

I've now simplified it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no