From: Drew Adams <drew.adams@oracle.com>
To: 18204@debbugs.gnu.org
Subject: bug#18204: 24.4.50; `ediff-file-compressed-p'
Date: Tue, 5 Aug 2014 14:49:29 -0700 (PDT) [thread overview]
Message-ID: <15f9dfe5-6bb6-4a94-9755-8c75cbb0eb70@default> (raw)
Could be improved from this:
(defun ediff-file-compressed-p (file)
(condition-case nil
(require 'jka-compr)
(error))
(if (featurep 'jka-compr)
(string-match (jka-compr-build-file-regexp) file)))
to this:
(defun ediff-file-compressed-p (file)
(and (require 'jka-compr nil t)
(string-match-p (jka-compr-build-file-regexp) file)))
Or just remove it altogether - it is used only once.
(Or provide it as a general function, outside `ediff-util'.)
In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/snapshot/trunk
--enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
-Ic:/Devel/emacs/include''
next reply other threads:[~2014-08-05 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 21:49 Drew Adams [this message]
2016-04-30 0:38 ` bug#18204: 24.4.50; `ediff-file-compressed-p' Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f9dfe5-6bb6-4a94-9755-8c75cbb0eb70@default \
--to=drew.adams@oracle.com \
--cc=18204@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.